From b8fe3f3944d9c5535b95f12da9f98f9ab5e6bee1 Mon Sep 17 00:00:00 2001 From: Mihail Anton Date: Wed, 11 May 2022 15:58:23 +0300 Subject: [PATCH 1/5] fix: template for GitHub issue --- .github/ISSUE_TEMPLATE.md | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index b2b8a6a..493ae60 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,25 +1,23 @@ ### Description of the issue: -*Try to be as clear as possible: Is it something wrong/missing in the model? Is it a simulation issue? PLEASE DELETE THIS LINE.* - + #### Expected feature/value/output: -*How the reaction/metabolite/gene/simulation result should look (cite literature if needed). PLEASE DELETE THIS LINE.* - + #### Current feature/value/output: -*How the reaction/metabolite/gene/simulation actually looks in the `main` branch. PLEASE DELETE THIS LINE.* - + #### Reproducing these results: -*Please attach any code used below (if it's python code replace the keyword "matlab" with "python". PLEASE DELETE THIS LINE.* + + ```matlab ``` **I hereby confirm that I have:** + + - [ ] Tested my code with [all requirements](https://github.com/SysBioChalmers/yeast-GEM#required-software---user) for running the model - [ ] Done this analysis in the `main` branch of the repository - [ ] Checked that a similar issue does not exist already - [ ] If needed, asked first in the [Gitter chat room](https://gitter.im/SysBioChalmers/yeast-GEM) about the issue - -*Note: replace [ ] with [X] to check the box. PLEASE DELETE THIS LINE* From 60c3e6c996e7f2a39b5917c1a6d0d13ada6c9fea Mon Sep 17 00:00:00 2001 From: Mihail Anton Date: Wed, 11 May 2022 16:01:47 +0300 Subject: [PATCH 2/5] fix: template for GItHub pull request --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5c2d4ab..6211d02 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,9 +1,8 @@ ### Main improvements in this PR: -*Try to be as clear as possible: Is it fixing/adding something in the model? Is it an additional test/function/dataset? PLEASE DELETE THIS LINE.* + **I hereby confirm that I have:** + - [ ] Tested my code on my own computer for running the model - [ ] Selected `devel` as a target branch - -*Note: replace [ ] with [X] to check the box. PLEASE DELETE THIS LINE* From ff8f06c3d689439bf01d4e6b022c049fc187d199 Mon Sep 17 00:00:00 2001 From: Mihail Anton Date: Thu, 12 May 2022 11:16:02 +0300 Subject: [PATCH 3/5] fix: remmove yeast-GEM links from issue template --- .github/ISSUE_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 493ae60..0396c9f 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -17,7 +17,7 @@ **I hereby confirm that I have:** -- [ ] Tested my code with [all requirements](https://github.com/SysBioChalmers/yeast-GEM#required-software---user) for running the model +- [ ] Tested my code with to run the model - [ ] Done this analysis in the `main` branch of the repository - [ ] Checked that a similar issue does not exist already -- [ ] If needed, asked first in the [Gitter chat room](https://gitter.im/SysBioChalmers/yeast-GEM) about the issue +- [ ] If needed, asked first in the Gitter chat room about the issue From c43157db19ef31dd61f755e0c88da2d0914ba69a Mon Sep 17 00:00:00 2001 From: Mihail Anton Date: Thu, 12 May 2022 11:18:58 +0300 Subject: [PATCH 4/5] style: lower checklists in the template --- .github/ISSUE_TEMPLATE.md | 8 ++++---- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 0396c9f..1195f86 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -17,7 +17,7 @@ **I hereby confirm that I have:** -- [ ] Tested my code with to run the model -- [ ] Done this analysis in the `main` branch of the repository -- [ ] Checked that a similar issue does not exist already -- [ ] If needed, asked first in the Gitter chat room about the issue +- [ ] tested my code with to run the model +- [ ] done this analysis in the `main` branch of the repository +- [ ] checked that a similar issue does not exist already +- [ ] if needed, asked first in the Gitter chat room about the issue diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6211d02..41db70e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,5 +4,5 @@ **I hereby confirm that I have:** -- [ ] Tested my code on my own computer for running the model -- [ ] Selected `devel` as a target branch +- [ ] tested my code on my own computer for running the model +- [ ] selected `devel` as a target branch From 5a786c9c15c9e3b011acb055ffec2467a356b4d5 Mon Sep 17 00:00:00 2001 From: Mihail Anton Date: Thu, 12 May 2022 11:21:03 +0300 Subject: [PATCH 5/5] fix: branch name in PR template --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 41db70e..e635553 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,4 +5,4 @@ - [ ] tested my code on my own computer for running the model -- [ ] selected `devel` as a target branch +- [ ] selected `develop` as a target branch