Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated validation #9

Closed
mihai-sysbio opened this issue Jun 29, 2020 · 7 comments
Closed

automated validation #9

mihai-sysbio opened this issue Jun 29, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request workflow workflow for curating GEM-type repos

Comments

@mihai-sysbio
Copy link
Member

mihai-sysbio commented Jun 29, 2020

This repository contains a branch (for) automated-validation. In short, the aim of that branch is to use GitHub Actions to validate all public repositories that follow standard-GEM and output a machine-readable file with the results, eg which version of the GEM follows which standard, MEMOTE results, cobrapy testing.
Documentation of the most up-to-date implementation is on the wiki.
Ideas and feedback are welcome!

edit: This could be implemented with eg Toil.

@haowang-bioinfo
Copy link
Member

Very good idea.

Based on the previously implemented PR #173 in HumanGEM, following checks may be included:

  1. yamllint
  2. cobrapy import

@mihai-sysbio
Copy link
Member Author

There has been some progress on this. The suggestions from @Hao-Chalmers are already implemented as workflow with GitHub Actions in the automated-validation branch, with results being automatically committed to that same branch in the results folder.
It looks like GitHub can schedule workflows only if they are available on the default branch (master), so it might be that the contents of the automated-validation branch would have to be moved to a separate repo.

@haowang-bioinfo haowang-bioinfo added the workflow workflow for curating GEM-type repos label Aug 14, 2020
@mihai-sysbio
Copy link
Member Author

As mentioned in #16, the SBML fle should be tested with MEMOTE.

@mihai-sysbio
Copy link
Member Author

As mentioned in #13, the SBML should contain taxonomy name, taxonomy ID, and reference genome.

@mihai-sysbio
Copy link
Member Author

From the continued discussion in #16: perhaps one can devise a test to check the compatibility of compartment abbreviations as metabolite identifier suffixes in cobrapy and cobratoolbox.

@draeger
Copy link
Collaborator

draeger commented Sep 15, 2020

I opened a separate discussion on the topic of identifiers and semantic overloading at #27.

@mihai-sysbio
Copy link
Member Author

For a clearer separation of concerns, the automated validation work has been promoted to a separate repository called standard-GEM-validation. The action points from this issue have been migrated to the new repository as distinct issues.
Since all future work will be carried out in that repository, this issue will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow workflow for curating GEM-type repos
Projects
None yet
Development

No branches or pull requests

3 participants