Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

The User Menu #3

Open
kellertuer opened this issue Dec 1, 2011 · 4 comments
Open

The User Menu #3

kellertuer opened this issue Dec 1, 2011 · 4 comments

Comments

@kellertuer
Copy link
Member

We should change the User menu, such that all three entires (My Account/Edit Account - Git Config - Logout) are themselves submenu entries, while the main Entrie (

  • ) is not a link, but the display of the actually logged in user name. That way It's clear, who is logged in and easier to understand, where the first menu link is.

    In style we shoud avoid the rounded-corders-Overlay in the submenu but just use 100%-width-color and (if using border at all) a non-rounded border in submenus.

johnyb added a commit that referenced this issue Dec 1, 2011
this was suggested by kellertuer in issue \#3
@johnyb
Copy link
Member

johnyb commented Dec 1, 2011

I created a new branch to play around with this issue. Find my suggestions in user_menu branch. What I did for now is to make the submenu items not use rounded borders

@johnyb
Copy link
Member

johnyb commented Dec 1, 2011

I also deployed it to http://anduintest.metameute.de/ together with the other changes, I proposed.

Still TODO:

  • change "My Account" to the current_user.nick attribute
    • make this not a link (don’t know if this is possible, though)
  • add a "My Account" link into the submenu Remove "Git Config" entry from menu

@kellertuer
Copy link
Member Author

We should also provide a border (was it #page-content ?) for the Sign in Form (and the other) forms. The Menu looks already better now without the rounded borders on submenu hover. I'll improve that soon to look even better.

@kellertuer
Copy link
Member Author

Oh and, you shoud add current_user.nick attribute and make My Account the first submenu entry, because My Account is a Link.

johnyb added a commit that referenced this issue Dec 18, 2011
this was suggested by kellertuer in issue \#3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants