-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Lisk and Lisk Sepolia logos #28763
Closed
Closed
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ricott1
force-pushed
the
feat/add-lisk-logo
branch
5 times, most recently
from
November 28, 2024 15:13
2a49d72
to
056cea2
Compare
The optional 'test-e2e-swap-playwright' job keeps failing but I think it's completely unrelated to this PR. |
ricott1
force-pushed
the
feat/add-lisk-logo
branch
3 times, most recently
from
December 4, 2024 09:29
3eb947c
to
36f4aa9
Compare
ricott1
force-pushed
the
feat/add-lisk-logo
branch
from
December 5, 2024 07:02
36f4aa9
to
e5be4c0
Compare
hjetpoluru
previously approved these changes
Dec 5, 2024
ricott1
force-pushed
the
feat/add-lisk-logo
branch
from
December 11, 2024 09:43
e5be4c0
to
62555f3
Compare
Hello, how can I get a second review for this? @hjetpoluru |
ricott1
force-pushed
the
feat/add-lisk-logo
branch
from
January 7, 2025 13:13
62555f3
to
967ace2
Compare
bergeron
changed the title
Feat: Add Lisk and Lisk Sepolia logos
feat: Add Lisk and Lisk Sepolia logos
Jan 16, 2025
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
## **Description** Adds logos for the list network. Taken from #28763 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29762?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Add the lisk network (mainnet and testnet) from https://chainlist.org/?search=lisk&testnets=true 2. Verify they have icons in the network selector ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="294" alt="Screenshot 2025-01-16 at 10 56 14 AM" src="https://github.com/user-attachments/assets/69fc2231-8882-4273-850f-f50d2d2c552c" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
merged here: #29762 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
N/A
Manual testing steps
Lisk
Lisk Sepolia
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist