Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Lisk and Lisk Sepolia logos #28763

Closed
wants to merge 3 commits into from

Conversation

ricott1
Copy link
Contributor

@ricott1 ricott1 commented Nov 27, 2024

Description

  • Add Lisk mainnet and testnet name and icon support.

Open in GitHub Codespaces

Related issues

Fixes:

N/A

Manual testing steps

Lisk

  1. Add Lisk network, from instance from https://blockscout.lisk.com/
  2. Click on the network selection button on the top left.
  3. Check the logo for the newly added Lisk network.

Lisk Sepolia

  1. Add Lisk Sepolia, from instance from https://sepolia-blockscout.lisk.com/
  2. Click on the network selection button on the top left.
  3. Check the logo for the newly added Lisk Sepolia network.

Screenshots/Recordings

Before

Screenshot 2024-11-27 at 10 53 54

After

Screenshot 2024-11-27 at 10 51 56

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ricott1 ricott1 requested a review from a team as a code owner November 27, 2024 10:01
@ricott1 ricott1 marked this pull request as draft November 27, 2024 10:01
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ricott1 ricott1 force-pushed the feat/add-lisk-logo branch 5 times, most recently from 2a49d72 to 056cea2 Compare November 28, 2024 15:13
@ricott1 ricott1 marked this pull request as ready for review November 28, 2024 15:41
@ricott1
Copy link
Contributor Author

ricott1 commented Nov 28, 2024

The optional 'test-e2e-swap-playwright' job keeps failing but I think it's completely unrelated to this PR.

@ricott1 ricott1 force-pushed the feat/add-lisk-logo branch 3 times, most recently from 3eb947c to 36f4aa9 Compare December 4, 2024 09:29
@ricott1 ricott1 requested a review from a team as a code owner December 4, 2024 09:29
@ricott1 ricott1 force-pushed the feat/add-lisk-logo branch from 36f4aa9 to e5be4c0 Compare December 5, 2024 07:02
hjetpoluru
hjetpoluru previously approved these changes Dec 5, 2024
@ricott1
Copy link
Contributor Author

ricott1 commented Dec 11, 2024

Hello, how can I get a second review for this? @hjetpoluru

@ricott1 ricott1 force-pushed the feat/add-lisk-logo branch from 62555f3 to 967ace2 Compare January 7, 2025 13:13
@bergeron bergeron changed the title Feat: Add Lisk and Lisk Sepolia logos feat: Add Lisk and Lisk Sepolia logos Jan 16, 2025
@bergeron bergeron mentioned this pull request Jan 16, 2025
7 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2025
## **Description**

Adds logos for the list network. Taken from
#28763

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29762?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Add the lisk network (mainnet and testnet) from
https://chainlist.org/?search=lisk&testnets=true
2. Verify they have icons in the network selector

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<img width="294" alt="Screenshot 2025-01-16 at 10 56 14 AM"
src="https://github.com/user-attachments/assets/69fc2231-8882-4273-850f-f50d2d2c552c"
/>


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@bergeron
Copy link
Contributor

merged here: #29762

@bergeron bergeron closed this Jan 16, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants