From 47921eb96040bb090a2deb2e117012cb2beee70d Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Thu, 29 Aug 2024 19:34:33 +0300 Subject: [PATCH 01/10] docs: Privacy settings manual scenarios --- ...lay NFT media\" toggle works correctly.md" | 44 +++++++++++++++++++ ..."IPFS gateway\" toggle works correctly.md" | 44 +++++++++++++++++++ ...details check\" toggle works correctly.md" | 43 ++++++++++++++++++ ...n address bar\" toggle works correctly.md" | 43 ++++++++++++++++++ 4 files changed, 174 insertions(+) create mode 100644 "test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" create mode 100644 "test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" create mode 100644 "test/manual-scenarios/privacy-settings/check \"Network details check\" toggle works correctly.md" create mode 100644 "test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" diff --git "a/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" new file mode 100644 index 000000000000..f8ad9db3f7bc --- /dev/null +++ "b/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" @@ -0,0 +1,44 @@ +# Manual test scenario for the 'Display NFT media' toggle + +Below is a summary of the validations included: + +* Validate that the 'Display NFT media' toggle is present in the Security & Privacy settings and is ON by default. +* Validate that the toggle can be turned on and off. +* Validate that when the toggle is turned on, MetaMask displays NFT media and data. +* Validate that NFT autodetection relies on this setting and won't be available when this is turned off. + +```markdown + +# Security & Privacy Settings: Verify "Display NFT media" Toggle Functionality + +# Feature: Toggle "Display NFT media" in Security & Privacy Settings + +In order to enhance user experience +As a user of the wallet extension +I want to toggle the "Display NFT media" option in the Security & Privacy Settings + +# Scenario: Default state of "Display NFT media" toggle is ON + +Given I am in Settings +When I click on the "Security & Privacy" tab +Then the "Display NFT media" toggle is set to ON by default + +# Scenario: "Display NFT media" toggle functionality + +Given I am on the Security & Privacy settings page +And the "Display NFT media" toggle is initially set to ON +When I click on the "Display NFT media" toggle icon +Then the toggle switch should visually indicate to OFF +When I click on the "Display NFT media" toggle icon again +Then the toggle switch should visually indicate to ON + +# Scenario: Verification of NFT media display functionality + +Given I am on the Security & Privacy settings page +And the "Display NFT media" toggle is set to ON +When I view my NFTs in MetaMask +Then MetaMask should display NFT media and data +And NFT autodetection should be available + + +``` diff --git "a/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" new file mode 100644 index 000000000000..a3e3ebe4194f --- /dev/null +++ "b/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" @@ -0,0 +1,44 @@ +# Manual test scenario for the 'IPFS gateway' toggle + +Below is a summary of the validations included: + +* Validate that the 'IPFS gateway' toggle is present in the Security & Privacy settings and is ON by default. +* Validate that the toggle can be turned on and off. +* Validate that when the toggle is turned on, MetaMask shows images of NFTs, displays information related to ENS addresses, and fetches icons for different tokens. + +```markdown + +# Security & Privacy Settings: Verify "IPFS gateway" Toggle Functionality + +# Feature: Toggle "IPFS gateway" in Security & Privacy Settings + +In order to enhance user experience +As a user of the wallet extension +I want to toggle the "IPFS gateway" option in the Security & Privacy Settings + +# Scenario: Default state of "IPFS gateway" toggle is ON + +Given I am in Settings +When I click on the "Security & Privacy" tab +Then the "IPFS gateway" toggle is set to ON by default + +# Scenario: "IPFS gateway" toggle functionality + +Given I am on the Security & Privacy settings page +And the "IPFS gateway" toggle is initially set to ON +When I click on the "IPFS gateway" toggle icon +Then the toggle switch should visually indicate to OFF +When I click on the "IPFS gateway" toggle icon again +Then the toggle switch should visually indicate to ON + +# Scenario: Verification of IPFS gateway functionality + +Given I am on the Security & Privacy settings page +And the "IPFS gateway" toggle is set to ON +When I view images of my NFTs +Or I enter ENS addresses in my browser's address bar +Or I view icons for different tokens +Then MetaMask should fetch this information + + +``` diff --git "a/test/manual-scenarios/privacy-settings/check \"Network details check\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"Network details check\" toggle works correctly.md" new file mode 100644 index 000000000000..2b5c9ccea355 --- /dev/null +++ "b/test/manual-scenarios/privacy-settings/check \"Network details check\" toggle works correctly.md" @@ -0,0 +1,43 @@ + +# Manual test scenario for the 'Network details check' toggle + +Below is a summary of the validations included: + +* Validate that the 'Network details check' toggle is present in the Security & Privacy settings and is ON by default. +* Validate that the toggle can be turned on and off. +* Validate that when the toggle is turned on, MetaMask checks the network details against the information provided by chainid.network when attempting to connect to a blockchain network. + +```markdown + +# Security & Privacy Settings: Verify "Network details check" Toggle Functionality + +# Feature: Toggle "Network details check" in Security & Privacy Settings + +In order to enhance user experience +As a user of the wallet extension +I want to toggle the "Network details check" option in the Security & Privacy Settings + +# Scenario: Default state of "Network details check" toggle is ON + +Given I am in Settings +When I click on the "Security & Privacy" tab +Then the "Network details check" toggle is set to ON by default + +# Scenario: "Network details check" toggle functionality + +Given I am on the Security & Privacy settings page +And the "Network details check" toggle is initially set to ON +When I click on the "Network details check" toggle icon +Then the toggle switch should visually indicate to OFF +When I click on the "Network details check" toggle icon again +Then the toggle switch should visually indicate to ON + +# Scenario: Verification of network details check functionality + +Given I am on the Security & Privacy settings page +And the "Network details check" toggle is set to ON +When I attempt to connect to a blockchain network +Then MetaMask should check the network details against the information provided by chainid.network + + +``` diff --git "a/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" new file mode 100644 index 000000000000..7aa3bff07c20 --- /dev/null +++ "b/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" @@ -0,0 +1,43 @@ +# Manual test scenario for the 'Show ENS domains in address bar' toggle + +Below is a summary of the validations included: + +* Validate that the 'Show ENS domains in address bar' toggle is present in the Security & Privacy settings and is ON by default. +* Validate that the toggle can be turned on and off. +* Validate that when the toggle is turned on, MetaMask checks with Ethereum's ENS contract to find the code connected to the ENS name. +* Validate that if the code links to IPFS, the content associated with it is displayed. + +```markdown + +# Security & Privacy Settings: Verify "Show ENS domains in address bar" Toggle Functionality + +# Feature: Toggle "Show ENS domains in address bar" in Security & Privacy Settings + +In order to enhance user experience +As a user of the wallet extension +I want to toggle the "Show ENS domains in address bar" option in the Security & Privacy Settings + +# Scenario: Default state of "Show ENS domains in address bar" toggle is ON + +Given I am in Settings +When I click on the "Security & Privacy" tab +Then the "Show ENS domains in address bar" toggle is set to ON by default + +# Scenario: "Show ENS domains in address bar" toggle functionality + +Given I am on the Security & Privacy settings page +And the "Show ENS domains in address bar" toggle is initially set to ON +When I click on the "Show ENS domains in address bar" toggle icon +Then the toggle switch should visually indicate to OFF +When I click on the "Show ENS domains in address bar" toggle icon again +Then the toggle switch should visually indicate to ON + +# Scenario: Verification of ENS domains display functionality + +Given I am on the Security & Privacy settings page +And the "Show ENS domains in address bar" toggle is set to ON +When I enter an ENS address in my browser's address bar +Then I should see the content associated with it + + +``` From bae8b205ec24540d92478097ba87e1a9c68b1bb0 Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Tue, 3 Sep 2024 13:51:09 +0300 Subject: [PATCH 02/10] fix network details check scenario --- extension-delivery | 1 + ...rk details check\" toggle works correctly.md" | 16 +++++++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) create mode 160000 extension-delivery diff --git a/extension-delivery b/extension-delivery new file mode 160000 index 000000000000..26af471af3f9 --- /dev/null +++ b/extension-delivery @@ -0,0 +1 @@ +Subproject commit 26af471af3f93a815e1860627341e94ceb891355 diff --git "a/test/manual-scenarios/privacy-settings/check \"Network details check\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"Network details check\" toggle works correctly.md" index 2b5c9ccea355..e42ebce5dac4 100644 --- "a/test/manual-scenarios/privacy-settings/check \"Network details check\" toggle works correctly.md" +++ "b/test/manual-scenarios/privacy-settings/check \"Network details check\" toggle works correctly.md" @@ -32,12 +32,22 @@ Then the toggle switch should visually indicate to OFF When I click on the "Network details check" toggle icon again Then the toggle switch should visually indicate to ON -# Scenario: Verification of network details check functionality +# Scenario: Verification of network details check functionality when toggle is ON Given I am on the Security & Privacy settings page And the "Network details check" toggle is set to ON -When I attempt to connect to a blockchain network -Then MetaMask should check the network details against the information provided by chainid.network +When I navigate to the Neworks tab +And I change the network name +Then the suggested name appears below +When I change the currency symbol +Then the suggested ticker appears below +# Scenario: Verification of network details check functionality when toggle is OFF + +Given I am on the Security & Privacy settings page +And the "Network details check" toggle is set to OFF +When I attempt to check network details from the Neworks tab +And I change the currency symbol +Then a message appears below indicating that verification is unavailable ``` From 2f0078de0689161228ab06e0dbe61649270633e0 Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Wed, 4 Sep 2024 18:41:54 +0300 Subject: [PATCH 03/10] . --- .../check \"Display NFT media\" toggle works correctly.md" | 1 - 1 file changed, 1 deletion(-) diff --git "a/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" index f8ad9db3f7bc..7a0ac3b2208e 100644 --- "a/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" +++ "b/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" @@ -38,7 +38,6 @@ Given I am on the Security & Privacy settings page And the "Display NFT media" toggle is set to ON When I view my NFTs in MetaMask Then MetaMask should display NFT media and data -And NFT autodetection should be available ``` From 1f68070445dfed9b35ee57bbee9365d760044a4b Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Wed, 4 Sep 2024 19:07:25 +0300 Subject: [PATCH 04/10] . --- ...ck \"IPFS gateway\" toggle works correctly.md" | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git "a/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" index a3e3ebe4194f..7828af8237b5 100644 --- "a/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" +++ "b/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" @@ -31,14 +31,19 @@ Then the toggle switch should visually indicate to OFF When I click on the "IPFS gateway" toggle icon again Then the toggle switch should visually indicate to ON -# Scenario: Verification of IPFS gateway functionality +# Scenario: Verification of IPFS gateway functionality with toggle ON Given I am on the Security & Privacy settings page And the "IPFS gateway" toggle is set to ON -When I view images of my NFTs -Or I enter ENS addresses in my browser's address bar -Or I view icons for different tokens -Then MetaMask should fetch this information +When I attempt to view images of my NFTs (e.g. ERC1155) stored on IPFS +Then MetaMask should successfully fetch and display this information + +# Scenario: Verification of IPFS gateway functionality with toggle OFF + +Given I am on the Security & Privacy settings page +And the "IPFS gateway" toggle is set to OFF +When I attempt to view images of my NFTs (e.g. ERC1155) stored on IPFS +Then MetaMask should display a placeholder image instead of the NFT media ``` From 9580f2eea98de7e65c834eaa6f0c86c95479cc57 Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Wed, 4 Sep 2024 19:22:41 +0300 Subject: [PATCH 05/10] . --- .../check \"IPFS gateway\" toggle works correctly.md" | 2 ++ 1 file changed, 2 insertions(+) diff --git "a/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" index 7828af8237b5..5b70c43d2854 100644 --- "a/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" +++ "b/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" @@ -44,6 +44,8 @@ Given I am on the Security & Privacy settings page And the "IPFS gateway" toggle is set to OFF When I attempt to view images of my NFTs (e.g. ERC1155) stored on IPFS Then MetaMask should display a placeholder image instead of the NFT media +And I should see a "Show" button +And clicking "Show" should prompt me to confirm turning ON IPFS resolution ``` From 754ecb506912c7b94c0c8ca204d664f4ca895f88 Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Wed, 4 Sep 2024 19:35:24 +0300 Subject: [PATCH 06/10] . --- .../check \"IPFS gateway\" toggle works correctly.md" | 3 ++- ...how ENS domains in address bar\" toggle works correctly.md" | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git "a/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" index 5b70c43d2854..f52b96866e7d 100644 --- "a/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" +++ "b/test/manual-scenarios/privacy-settings/check \"IPFS gateway\" toggle works correctly.md" @@ -4,7 +4,8 @@ Below is a summary of the validations included: * Validate that the 'IPFS gateway' toggle is present in the Security & Privacy settings and is ON by default. * Validate that the toggle can be turned on and off. -* Validate that when the toggle is turned on, MetaMask shows images of NFTs, displays information related to ENS addresses, and fetches icons for different tokens. +* Validate that when the toggle is turned on, MetaMask shows images of NFTs +* Validate that when the toggle is turned off, NFT images are replaced by placeholders and I am prompted to turn on IPFS resolution ```markdown diff --git "a/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" index 7aa3bff07c20..454a04570c18 100644 --- "a/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" +++ "b/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" @@ -4,8 +4,7 @@ Below is a summary of the validations included: * Validate that the 'Show ENS domains in address bar' toggle is present in the Security & Privacy settings and is ON by default. * Validate that the toggle can be turned on and off. -* Validate that when the toggle is turned on, MetaMask checks with Ethereum's ENS contract to find the code connected to the ENS name. -* Validate that if the code links to IPFS, the content associated with it is displayed. +* Validate that when the toggle is turned on, ENS domain name is displayed alongside the public address ```markdown From c1a0978c6b618e219f962ff3e5b987d36a7d6af5 Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Thu, 5 Sep 2024 17:25:03 +0300 Subject: [PATCH 07/10] . --- extension-delivery | 1 - 1 file changed, 1 deletion(-) delete mode 160000 extension-delivery diff --git a/extension-delivery b/extension-delivery deleted file mode 160000 index 26af471af3f9..000000000000 --- a/extension-delivery +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 26af471af3f93a815e1860627341e94ceb891355 From 90f7f93f7e97709d03ccb2b955ca09e915a37a6f Mon Sep 17 00:00:00 2001 From: Harika <153644847+hjetpoluru@users.noreply.github.com> Date: Fri, 6 Sep 2024 13:22:34 +0000 Subject: [PATCH 08/10] Removed the folder extension-delivery --- extension-delivery | 1 - 1 file changed, 1 deletion(-) delete mode 160000 extension-delivery diff --git a/extension-delivery b/extension-delivery deleted file mode 160000 index 26af471af3f9..000000000000 --- a/extension-delivery +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 26af471af3f93a815e1860627341e94ceb891355 From 7770e0303dbd89bb592ae1304ec75a616bf45b80 Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Tue, 10 Sep 2024 12:03:44 +0300 Subject: [PATCH 09/10] . --- ..."Show ENS domains in address bar\" toggle works correctly.md" | 1 + 1 file changed, 1 insertion(+) diff --git "a/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" index 454a04570c18..99b37d442ea6 100644 --- "a/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" +++ "b/test/manual-scenarios/privacy-settings/check \"Show ENS domains in address bar\" toggle works correctly.md" @@ -40,3 +40,4 @@ Then I should see the content associated with it ``` + From 2aac4677cee26d4a475d4ffbdbe50934abc12602 Mon Sep 17 00:00:00 2001 From: Marina Boboc <120041701+benjisclowder@users.noreply.github.com> Date: Tue, 10 Sep 2024 15:29:38 +0300 Subject: [PATCH 10/10] . --- .../check \"Display NFT media\" toggle works correctly.md" | 1 + 1 file changed, 1 insertion(+) diff --git "a/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" "b/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" index 7a0ac3b2208e..ce8153ffac7f 100644 --- "a/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" +++ "b/test/manual-scenarios/privacy-settings/check \"Display NFT media\" toggle works correctly.md" @@ -41,3 +41,4 @@ Then MetaMask should display NFT media and data ``` +