From 5648f9c29c54cff7d29746ae9c025f1c0d923876 Mon Sep 17 00:00:00 2001 From: Nicholas Gambino Date: Thu, 1 Aug 2024 11:03:12 -0700 Subject: [PATCH 01/23] Bump Avatar Network marginRight to 16px --- ui/components/multichain/token-list-item/token-list-item.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/components/multichain/token-list-item/token-list-item.js b/ui/components/multichain/token-list-item/token-list-item.js index ed69d6638b37..22dcd69233ae 100644 --- a/ui/components/multichain/token-list-item/token-list-item.js +++ b/ui/components/multichain/token-list-item/token-list-item.js @@ -229,7 +229,7 @@ export const TokenListItem = ({ } /> } - marginRight={3} + marginRight={4} className="multichain-token-list-item__badge" > Date: Thu, 1 Aug 2024 11:11:57 -0700 Subject: [PATCH 02/23] Tweak top & bottom padding on AssetList item --- ui/components/multichain/token-list-item/token-list-item.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/components/multichain/token-list-item/token-list-item.js b/ui/components/multichain/token-list-item/token-list-item.js index 22dcd69233ae..66408d58bb6a 100644 --- a/ui/components/multichain/token-list-item/token-list-item.js +++ b/ui/components/multichain/token-list-item/token-list-item.js @@ -189,7 +189,10 @@ export const TokenListItem = ({ })} display={Display.Flex} flexDirection={FlexDirection.Row} - padding={4} + paddingTop={2} + paddingBottom={2} + paddingLeft={4} + paddingRight={4} data-testid="multichain-token-list-button" {...(onClick && { as: 'a', From 7dd7a1d67f92147869a213495408ea6e7a417fd7 Mon Sep 17 00:00:00 2001 From: Nicholas Gambino Date: Thu, 1 Aug 2024 12:00:50 -0700 Subject: [PATCH 03/23] Bump border width on AvatarBase and set to default background --- .../component-library/avatar-network/avatar-network.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/components/component-library/avatar-network/avatar-network.tsx b/ui/components/component-library/avatar-network/avatar-network.tsx index 487f2ad7ee05..634023d71557 100644 --- a/ui/components/component-library/avatar-network/avatar-network.tsx +++ b/ui/components/component-library/avatar-network/avatar-network.tsx @@ -21,7 +21,7 @@ export const AvatarNetwork: AvatarNetworkComponent = React.forwardRef( src, showHalo, color = TextColor.textDefault, - backgroundColor = BackgroundColor.backgroundAlternative, + backgroundColor = BackgroundColor.backgroundDefault, borderColor = BorderColor.transparent, className = '', ...props @@ -55,6 +55,7 @@ export const AvatarNetwork: AvatarNetworkComponent = React.forwardRef( {...{ backgroundColor, borderColor, + borderWidth: 2, color, ...(props as AvatarBaseProps), }} From 50affff85a0d1e5fed6f35ef2e4fbf68a49a7642 Mon Sep 17 00:00:00 2001 From: Nicholas Gambino Date: Thu, 1 Aug 2024 12:46:32 -0700 Subject: [PATCH 04/23] Convert stakeableTitle to in-line rather than Flexbox to avoid incosistent padding --- .../multichain/token-list-item/token-list-item.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/ui/components/multichain/token-list-item/token-list-item.js b/ui/components/multichain/token-list-item/token-list-item.js index 66408d58bb6a..a17bc46f2d63 100644 --- a/ui/components/multichain/token-list-item/token-list-item.js +++ b/ui/components/multichain/token-list-item/token-list-item.js @@ -128,11 +128,10 @@ export const TokenListItem = ({ as="button" backgroundColor={BackgroundColor.transparent} data-testid={`staking-entrypoint-${chainId}`} - display={Display.InlineFlex} - flexDirection={FlexDirection.Row} - alignItems={AlignItems.center} gap={1} paddingInline={0} + paddingInlineStart={1} + paddingInlineEnd={1} tabIndex="0" onClick={(e) => { e.preventDefault(); @@ -159,7 +158,12 @@ export const TokenListItem = ({ }} > - + {t('stake')} Date: Thu, 1 Aug 2024 12:53:56 -0700 Subject: [PATCH 05/23] Bump font weight on Stake button to match token title --- ui/components/multichain/token-list-item/token-list-item.js | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/components/multichain/token-list-item/token-list-item.js b/ui/components/multichain/token-list-item/token-list-item.js index a17bc46f2d63..4493e268d33d 100644 --- a/ui/components/multichain/token-list-item/token-list-item.js +++ b/ui/components/multichain/token-list-item/token-list-item.js @@ -163,6 +163,7 @@ export const TokenListItem = ({ color={TextColor.primaryDefault} paddingInlineStart={1} paddingInlineEnd={1} + fontWeight={FontWeight.Medium} > {t('stake')} From 4f53c6ba5cf35453673c0ab3c3e4e33198e94413 Mon Sep 17 00:00:00 2001 From: Nicholas Gambino Date: Thu, 1 Aug 2024 14:36:39 -0700 Subject: [PATCH 06/23] Update snapshots --- .../__snapshots__/nft-details.test.js.snap | 2 +- .../__snapshots__/token-cell.test.js.snap | 6 +++--- .../incoming-transaction-toggle.test.js.snap | 14 +++++++------- .../__snapshots__/avatar-network.test.tsx.snap | 2 +- .../__snapshots__/picker-network.test.tsx.snap | 2 +- .../__snapshots__/app-header.test.js.snap | 4 ++-- .../__snapshots__/asset-picker.test.tsx.snap | 4 ++-- .../network-list-item.test.js.snap | 2 +- .../permissions-page.test.js.snap | 2 +- .../__snapshots__/network-picker.test.tsx.snap | 2 +- .../__snapshots__/token-list-item.test.js.snap | 6 +++--- .../__snapshots__/asset-page.test.tsx.snap | 18 +++++++++--------- ...age-container-header.component.test.js.snap | 2 +- .../header/__snapshots__/header.test.tsx.snap | 4 ++-- .../contract-interaction.test.tsx.snap | 4 ++-- ...ature-request-header.component.test.js.snap | 4 ++-- .../confirm-send-ether.test.js.snap | 4 ++-- .../__snapshots__/confirm.test.tsx.snap | 8 ++++---- .../add-ethereum-chain.test.js.snap | 2 +- .../switch-ethereum-chain.test.js.snap | 12 ++++++------ .../__snapshots__/security-tab.test.js.snap | 10 +++++----- 21 files changed, 57 insertions(+), 57 deletions(-) diff --git a/ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap b/ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap index d03df016c1b3..992b0a4509fa 100644 --- a/ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap +++ b/ui/components/app/assets/nfts/nft-details/__snapshots__/nft-details.test.js.snap @@ -61,7 +61,7 @@ exports[`NFT Details should match minimal props and state snapshot 1`] = ` style="top: -4px; right: -4px;" >
C diff --git a/ui/components/app/assets/token-cell/__snapshots__/token-cell.test.js.snap b/ui/components/app/assets/token-cell/__snapshots__/token-cell.test.js.snap index a3ddde203929..00a7ed7ca3fa 100644 --- a/ui/components/app/assets/token-cell/__snapshots__/token-cell.test.js.snap +++ b/ui/components/app/assets/token-cell/__snapshots__/token-cell.test.js.snap @@ -7,12 +7,12 @@ exports[`Token Cell should match snapshot 1`] = ` data-testid="multichain-token-list-item" >
?
diff --git a/ui/components/app/incoming-trasaction-toggle/__snapshots__/incoming-transaction-toggle.test.js.snap b/ui/components/app/incoming-trasaction-toggle/__snapshots__/incoming-transaction-toggle.test.js.snap index faf8faf6dedf..2d773a7541cf 100644 --- a/ui/components/app/incoming-trasaction-toggle/__snapshots__/incoming-transaction-toggle.test.js.snap +++ b/ui/components/app/incoming-trasaction-toggle/__snapshots__/incoming-transaction-toggle.test.js.snap @@ -23,7 +23,7 @@ exports[`IncomingTransactionToggle should render existing incoming transaction p class="mm-box network-toggle-wrapper__overflow-container mm-box--display-flex mm-box--gap-4 mm-box--align-items-center mm-box--width-full mm-box--background-color-transparent" >
Ethereum Mainnet logo
Linea Mainnet logo
F
@@ -280,7 +280,7 @@ exports[`IncomingTransactionToggle should render existing incoming transaction p class="mm-box network-toggle-wrapper__overflow-container mm-box--display-flex mm-box--gap-4 mm-box--align-items-center mm-box--width-full mm-box--background-color-transparent" >
G
@@ -363,7 +363,7 @@ exports[`IncomingTransactionToggle should render existing incoming transaction p class="mm-box network-toggle-wrapper__overflow-container mm-box--display-flex mm-box--gap-4 mm-box--align-items-center mm-box--width-full mm-box--background-color-transparent" >
S
@@ -446,7 +446,7 @@ exports[`IncomingTransactionToggle should render existing incoming transaction p class="mm-box network-toggle-wrapper__overflow-container mm-box--display-flex mm-box--gap-4 mm-box--align-items-center mm-box--width-full mm-box--background-color-transparent" >
Linea Goerli logo
Linea Sepolia logo
I
diff --git a/ui/components/multichain/app-header/__snapshots__/app-header.test.js.snap b/ui/components/multichain/app-header/__snapshots__/app-header.test.js.snap index d22597edd89f..b8ed9a751799 100644 --- a/ui/components/multichain/app-header/__snapshots__/app-header.test.js.snap +++ b/ui/components/multichain/app-header/__snapshots__/app-header.test.js.snap @@ -15,7 +15,7 @@ exports[`App Header locked state matches snapshot: locked 1`] = ` data-testid="network-display" >