From 4913f77a0e59d27158c4604c81f98a79b40992c0 Mon Sep 17 00:00:00 2001 From: sleepytanya <104780023+sleepytanya@users.noreply.github.com> Date: Sun, 10 Mar 2024 01:56:28 -0500 Subject: [PATCH 1/2] add failing contract --- .../deploy failing transaction.csv | 15 ++++++++++++ .../4. tokens/approve erc20 token.csv | 23 ++++++++++++------- 2 files changed, 30 insertions(+), 8 deletions(-) create mode 100644 test/scenarios/3. transactions/deploy failing transaction.csv diff --git a/test/scenarios/3. transactions/deploy failing transaction.csv b/test/scenarios/3. transactions/deploy failing transaction.csv new file mode 100644 index 000000000000..dad62e210e18 --- /dev/null +++ b/test/scenarios/3. transactions/deploy failing transaction.csv @@ -0,0 +1,15 @@ +Step,Test steps,Test data,Expected result,Notes +1,Open the extension.,,The Welcome Back screen is shown., +2,Proceed to Unlock the wallet.,password (8 characters min).,The Ether balance is shown on the overview. The wallet address is shown on the overview. The selected network is Ethereum Mainnet. , +3,Switch networks to a test network.,e.g. Sepolia,The Sepolia balance is shown on the overview. The wallet address is shown on the overview. The selected network is Sepolia., +4,Open the test dapp in another tab.,https://metamask.github.io/test-dapp/,, +5,Proceed to connect with MetaMask. ,,, +6,Connect with the current account. ,,, +7,Deploy failing contract.,,"MetaMask popup with estimated gas fees, total fees appears.", +8,Proceed to confirm contract deployment and wait for the transaction to be confirmed.,,"Contract deployment status on MetamMask Activity list displayed as ""Confirmed"". ""Send failing transaction"" button on the test dapp window is active.", +9,Deploy failing transaction.,,"MetaMask popup with contract interaction screen appears. Warning on the red background is displayed: ""We were not able to estimate gas. There might be an error in the contract and this transaction may fail."" The warning includes a link ""I want to proceed anyway"".", +10,"Click ""I want to proceed anyway"" and confirm transaction.",,, +11,Switch back to the wallet.,,, +12,Open the Activity tab.,,"""Contract interaction"" transaction in ""Pending"" status is displayed.", +13,"Allow some time for the transaction status to update to ""Failed"".",,,Waiting times may vary based on network conditions. +14,Proceed to view the transaction on the block explorer.,,Block explorer opens in the new tab., \ No newline at end of file diff --git a/test/scenarios/4. tokens/approve erc20 token.csv b/test/scenarios/4. tokens/approve erc20 token.csv index 674bc69c4d0d..636ea8025c7d 100644 --- a/test/scenarios/4. tokens/approve erc20 token.csv +++ b/test/scenarios/4. tokens/approve erc20 token.csv @@ -1,15 +1,22 @@ Step,Test steps,Test data,Expected result,Notes 1,Open the extension.,,The Welcome Back screen is shown., -2,Proceed to Unlock the wallet.,password (8 characters min).,"The Ether balance is shown on the overview. The wallet address is shown on the overview. The selected network is Ethereum Mainnet. ", +2,Proceed to Unlock the wallet.,password (8 characters min).,The Ether balance is shown on the overview. The wallet address is shown on the overview. The selected network is Ethereum Mainnet. , 3,Switch networks to a test network.,e.g. Sepolia,The Sepolia balance is shown on the overview. The wallet address is shown on the overview. The selected network is Sepolia., 4,Open the test dapp in another tab.,https://metamask.github.io/test-dapp/,, -5,"Proceed to connect with MetaMask. ",,, -6,"Connect with the current account. ",,, -7,Deploy the token contract.,,, -8,Confirm the transaction and wait for it to complete.,,, -9,Switch to the wallet and open the activity list item.,,"The contract deployment transaction status, nonce, amount, gas and total are shown in the item details.", -10,Proceed to view the transaction on the block explorer.,,The block explorer opens in a new tab., -11,"In the test dapp, proceed to approve tokens. ",,"Spending cap request notification window is shown. The token icon and symbol TST are shown. An input field is displayed, allow user to edit the spending cap amount .", +5,Proceed to connect with MetaMask. ,,, +6,Connect with the current account. ,,, +7,Create Legacy transaction,,"MetaMask popup with estimated gas fees, total fees appears.", +8,"Do not confirm the transaction, click outside of the popup on the test dapp window.",,"Test dapp window is active. MetaMask extension icon in the browser has blue badge, showing the number of approval requests - '1'. MetaMask popup is behind the browser.", +9,Create another Legacy or EIP1559 transaction.,,"MetaMask popup with estimated gas fees, total fees appears. On the top of the aproval modal text with the ""1 of 2 requests waiting to be acknowledged"" is displayed. Arrow buttons '>' and '>>' displayed in the right upper corner of the approval modal.", +10,"Do not confirm the transaction, click outside of the popup on the test dapp window.",,"Test dapp window is active. MetaMask extension icon in the browser has blue badge, showing the number of approval requests - '2'. MetaMask popup is behind the browser.", +,Create another Legacy or EIP1559 transaction.,,"MetaMask popup with estimated gas fees, total fees appears. On the top of the aproval modal text with the ""1 of 3 requests waiting to be acknowledged"" is displayed. Right arrow buttons '>' and '>>' displayed in the right upper corner of the approval modal.", +,Click single right arrow '>' on the top of the approval modal.,,"The approval request for the next (second) transaction is displayed. Message ""2 of 3 requests waiying to be acknowledged"" is shown on the top of the approval modal. Right arrow buttons '>' and '>>' displayed in the right upper corner of the approval modal.", +,Click single right arrow '>' on the top of the approval modal.,,"The approval request for the next (third) transaction is displayed. Message ""3 of 3 requests waiying to be acknowledged"" is shown on the top of the approval modal. Left arrow buttons are in the left upper corner of the approval modal.", +,Click double left arrow '<<' on top of the approval modal.,,"The approval request for the first transaction is displayed. Message ""1 of 3 requests waiying to be acknowledged"" is shown on the top of the approval modal. Right arrow buttons '>' and '>>' displayed in the right upper corner of the approval modal.", +,,,, +,,,, +,,,, +11,"In the test dapp, proceed to approve tokens. J",,"Spending cap request notification window is shown. The token icon and symbol TST are shown. An input field is displayed, allow user to edit the spending cap amount .", 12,Proceed to approve the spending cap request.,,, 13,Switch back to the wallet.,,"The transaction ""Approve TST spending cap"" appears in the activity list.", 14,Open the activity list item.,,"The transaction status, recipient's address, nonce, amount, gas and total are shown in the item details.", From 01bb0d2f1e38ef4833a44fac7284d7168c9d43bb Mon Sep 17 00:00:00 2001 From: sleepytanya <104780023+sleepytanya@users.noreply.github.com> Date: Sun, 10 Mar 2024 12:56:03 -0400 Subject: [PATCH 2/2] revert approve erc20 token.csv --- .../4. tokens/approve erc20 token.csv | 25 +++++++------------ 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/test/scenarios/4. tokens/approve erc20 token.csv b/test/scenarios/4. tokens/approve erc20 token.csv index 636ea8025c7d..fedb737aba76 100644 --- a/test/scenarios/4. tokens/approve erc20 token.csv +++ b/test/scenarios/4. tokens/approve erc20 token.csv @@ -1,24 +1,17 @@ Step,Test steps,Test data,Expected result,Notes 1,Open the extension.,,The Welcome Back screen is shown., -2,Proceed to Unlock the wallet.,password (8 characters min).,The Ether balance is shown on the overview. The wallet address is shown on the overview. The selected network is Ethereum Mainnet. , +2,Proceed to Unlock the wallet.,password (8 characters min).,"The Ether balance is shown on the overview. The wallet address is shown on the overview. The selected network is Ethereum Mainnet. ", 3,Switch networks to a test network.,e.g. Sepolia,The Sepolia balance is shown on the overview. The wallet address is shown on the overview. The selected network is Sepolia., 4,Open the test dapp in another tab.,https://metamask.github.io/test-dapp/,, -5,Proceed to connect with MetaMask. ,,, -6,Connect with the current account. ,,, -7,Create Legacy transaction,,"MetaMask popup with estimated gas fees, total fees appears.", -8,"Do not confirm the transaction, click outside of the popup on the test dapp window.",,"Test dapp window is active. MetaMask extension icon in the browser has blue badge, showing the number of approval requests - '1'. MetaMask popup is behind the browser.", -9,Create another Legacy or EIP1559 transaction.,,"MetaMask popup with estimated gas fees, total fees appears. On the top of the aproval modal text with the ""1 of 2 requests waiting to be acknowledged"" is displayed. Arrow buttons '>' and '>>' displayed in the right upper corner of the approval modal.", -10,"Do not confirm the transaction, click outside of the popup on the test dapp window.",,"Test dapp window is active. MetaMask extension icon in the browser has blue badge, showing the number of approval requests - '2'. MetaMask popup is behind the browser.", -,Create another Legacy or EIP1559 transaction.,,"MetaMask popup with estimated gas fees, total fees appears. On the top of the aproval modal text with the ""1 of 3 requests waiting to be acknowledged"" is displayed. Right arrow buttons '>' and '>>' displayed in the right upper corner of the approval modal.", -,Click single right arrow '>' on the top of the approval modal.,,"The approval request for the next (second) transaction is displayed. Message ""2 of 3 requests waiying to be acknowledged"" is shown on the top of the approval modal. Right arrow buttons '>' and '>>' displayed in the right upper corner of the approval modal.", -,Click single right arrow '>' on the top of the approval modal.,,"The approval request for the next (third) transaction is displayed. Message ""3 of 3 requests waiying to be acknowledged"" is shown on the top of the approval modal. Left arrow buttons are in the left upper corner of the approval modal.", -,Click double left arrow '<<' on top of the approval modal.,,"The approval request for the first transaction is displayed. Message ""1 of 3 requests waiying to be acknowledged"" is shown on the top of the approval modal. Right arrow buttons '>' and '>>' displayed in the right upper corner of the approval modal.", -,,,, -,,,, -,,,, -11,"In the test dapp, proceed to approve tokens. J",,"Spending cap request notification window is shown. The token icon and symbol TST are shown. An input field is displayed, allow user to edit the spending cap amount .", +5,"Proceed to connect with MetaMask. ",,, +6,"Connect with the current account. ",,, +7,Deploy the token contract.,,, +8,Confirm the transaction and wait for it to complete.,,, +9,Switch to the wallet and open the activity list item.,,"The contract deployment transaction status, nonce, amount, gas and total are shown in the item details.", +10,Proceed to view the transaction on the block explorer.,,The block explorer opens in a new tab., +11,"In the test dapp, proceed to approve tokens. ",,"Spending cap request notification window is shown. The token icon and symbol TST are shown. An input field is displayed, allow user to edit the spending cap amount .", 12,Proceed to approve the spending cap request.,,, 13,Switch back to the wallet.,,"The transaction ""Approve TST spending cap"" appears in the activity list.", 14,Open the activity list item.,,"The transaction status, recipient's address, nonce, amount, gas and total are shown in the item details.", 15,Expand the Activity log.,,"The created, submitted and confirmed activity are shown in the activity log.", -16,Proceed to view the transaction on the block explorer.,,The block explorer opens in a new tab., \ No newline at end of file +16,Proceed to view the transaction on the block explorer.,,The block explorer opens in a new tab.,