From ce7f8fabb17d23a80452714c21030618017f3c55 Mon Sep 17 00:00:00 2001 From: "Akintayo A. Olusegun" Date: Tue, 5 Mar 2024 15:15:06 +0300 Subject: [PATCH 1/2] Personal sign test scenarios with hardware wallet --- .../personal sign with hardware wallet.csv | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 test/scenarios/13. sign/personal sign with hardware wallet.csv diff --git a/test/scenarios/13. sign/personal sign with hardware wallet.csv b/test/scenarios/13. sign/personal sign with hardware wallet.csv new file mode 100644 index 000000000000..4af5aaab4336 --- /dev/null +++ b/test/scenarios/13. sign/personal sign with hardware wallet.csv @@ -0,0 +1,16 @@ +Steps,Test Steps,Preconditions,Test Data,Expected Result,Notes +1,Open the extension.,,,The Welcome Back screen is shown., +2,Proceed to unlock the wallet.,,password (8 characters min).,"The Ether balance is shown on the overview. The wallet address is shown on the overview.", +3,"Click on account menu icon. Click ""Add account or hardware wallet"".",,,"The ""Add account"" modal is shown.", +4,"On ""Add account"" modal, click ""Add hardware wallet"" button.",,,"""Connect a hardware wallet"" screen is shown. User can choose between different options to connect a hardware: Ledger, Trezor, Lattice, or QR-based. ""Continue"" button is disabled.", +5,Choose an option to connect hardware wallet.,We need to have a hardware wallet set up to test this functionality.,"e.g. choose ""Ledger""","""Continue"" button is enabled.", +6,"Plug the hardware wallet directly into computer, then unlock it.",,Password for hardware wallet,"Hardware wallet is detected by MetaMask. ""Select an account"" screen is shown on MetaMask, accounts on hardware wallet are shown on this screen.","If you use Ledger, you need to open the Ethereum app on Ledger. If you use Trezor, make sure you use the correct passphrase." +7,"Choose one or multiples accounts that user wants to connect. Then click ""Unlock"".",,,, +8,Click account menu icon to open accounts list.,,,"In accounts list, all selected hardware wallet accounts are shown, and they are all flagged with harware wallet name to be distinguished from other accounts.", +9,Select one hardware wallet account.,,,"The Ether balance for the selected hardware wallet account is shown on the overview. The selected account address is shown on the overview.", +10,Open the test dapp in another tab.,,https://metamask.github.io/test-dapp/,, +11,Click Connect.,,,"The MetaMask popup is opened with the Connect with MetaMask screen displayed. Your imported hardware wallet account is selected.", +12,Click Next and Connect with the hardware wallet account.,,,"The MetaMask popup is closed. You are connected to the test dapp.", +13,"Click Sign in the ""Personal Sign"" section".,,,"The info modal instructions for signing with hardware wallet is displayed. The signature message is in Plain Text.", +14,"Click Sign in the displayed modal. Then the Accept the Signature in the hardware wallet device.,,,The signature hash is displayed on the test dapp., +15,Verify signed hash.,,,The signed address is correctly verified.,The address shown in the test dapp is the same as the hardware wallet account. \ No newline at end of file From a376c30fbaae6d76519d74c18f3748f077168a5b Mon Sep 17 00:00:00 2001 From: "Akintayo A. Olusegun" Date: Wed, 6 Mar 2024 19:37:06 +0300 Subject: [PATCH 2/2] Fix formatting --- .../scenarios/13. sign/personal sign with hardware wallet.csv | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/scenarios/13. sign/personal sign with hardware wallet.csv b/test/scenarios/13. sign/personal sign with hardware wallet.csv index 4af5aaab4336..50cf9ecdff70 100644 --- a/test/scenarios/13. sign/personal sign with hardware wallet.csv +++ b/test/scenarios/13. sign/personal sign with hardware wallet.csv @@ -11,6 +11,6 @@ Steps,Test Steps,Preconditions,Test Data,Expected Result,Notes 10,Open the test dapp in another tab.,,https://metamask.github.io/test-dapp/,, 11,Click Connect.,,,"The MetaMask popup is opened with the Connect with MetaMask screen displayed. Your imported hardware wallet account is selected.", 12,Click Next and Connect with the hardware wallet account.,,,"The MetaMask popup is closed. You are connected to the test dapp.", -13,"Click Sign in the ""Personal Sign"" section".,,,"The info modal instructions for signing with hardware wallet is displayed. The signature message is in Plain Text.", -14,"Click Sign in the displayed modal. Then the Accept the Signature in the hardware wallet device.,,,The signature hash is displayed on the test dapp., +13,"Click Sign in the ""Personal Sign"" section",,,"The info modal instructions for signing with hardware wallet is displayed. The signature message is in Plain Text.", +14,"Click Sign in the displayed modal. Then the Accept the Signature in the hardware wallet device.",,,The signature hash is displayed on the test dapp., 15,Verify signed hash.,,,The signed address is correctly verified.,The address shown in the test dapp is the same as the hardware wallet account. \ No newline at end of file