feat: Nonce is always editable in advanced details view

[pedronfigueiredo]

Description

Previously, the nonce can only be edited if the option to do it is enabled in the corresponding settings toggle. This PR removes the link with that toggle in the redesigned transaction screens.

Related issues

Fixes: #29512

Manual testing steps

1. Go to the test dApp
2. Disable Advanced > Customize transaction nonce in settings
3. Create a send eth transaction
4. Toggle on advanced details
5. The edit nonce icon should be visible in the confirmation screen

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [714eecf]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1836 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1594	2276	1830	178	86
		domContentLoaded	1585	2192	1794	172	82
		load	1594	2281	1836	177	85
		domInteractive	26	107	41	20	10
		backgroundConnect	10	89	44	26	12
		firstReactRender	18	83	45	26	12
		getState	6	55	18	18	8
		initialActions	0	1	0	0	0
		loadScripts	1113	1750	1338	171	82
		setupStore	6	11	9	2	1
		uiStartup	1852	2601	2101	190	91

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -52 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [8d54e1b]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1734 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	1952	1555	426	205
		domContentLoaded	1343	2353	1709	219	105
		load	1352	2365	1734	212	102
		domInteractive	24	118	46	26	13
		backgroundConnect	8	59	31	18	9
		firstReactRender	16	97	48	30	15
		getState	6	80	22	21	10
		initialActions	0	1	0	0	0
		loadScripts	981	1768	1277	161	77
		setupStore	6	38	12	9	4
		uiStartup	1597	2645	2040	262	126

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -52 Bytes (-0.00%)
• common: 0 Bytes (0.00%)