fix (cherry-pick): navigation between watch asset approvals #29279 #29401

matthewwalsh0 · 2024-12-20T17:55:57Z

Description

Cherry-pick of #29279 for release 12.10.0.

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** Ignore any additional watch token and watch NFT approvals in the confirmation navigation, since both types of watch asset confirmation combine data from multiple approval requests. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29279?quickstart=1) ## **Related issues** Fixes: #29189 ## **Manual testing steps** See issue. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-12-20T18:28:27Z

Builds ready [c9d0370]

Page Load Metrics (1785 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1518	2117	1787	192	92
		domContentLoaded	1493	2092	1760	189	91
		load	1516	2115	1785	192	92
		domInteractive	24	103	46	27	13
		backgroundConnect	10	81	25	17	8
		firstReactRender	16	76	38	24	11
		getState	5	57	24	20	9
		initialActions	0	1	0	0	0
		loadScripts	1089	1552	1303	152	73
		setupStore	7	63	13	16	7
		uiStartup	1673	2391	2029	216	104

Bundle size diffs [🚨 Warning! Bundle size has increased!]

matthewwalsh0 added the team-confirmations Push issues to confirmations team label Dec 20, 2024

matthewwalsh0 requested review from a team as code owners December 20, 2024 17:55

pedronfigueiredo approved these changes Dec 20, 2024

View reviewed changes

matthewwalsh0 merged commit b24c4e9 into Version-v12.10.0 Dec 20, 2024
68 checks passed

matthewwalsh0 deleted the fix/cherry-pick-watch-asset-navigation branch December 20, 2024 22:34

github-actions bot locked and limited conversation to collaborators Dec 20, 2024