Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use break-word for Snaps UI text wrapping #29387

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 20, 2024

Description

Use break-word for Snaps UI text wrapping to prevent squishing of text in Section among other components.

Open in GitHub Codespaces

Related issues

Fixes: MetaMask/snaps#2816

Screenshots/Recordings

image

@FrederikBolding FrederikBolding requested a review from a team as a code owner December 20, 2024 13:40
@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Dec 20, 2024
david0xd
david0xd previously approved these changes Dec 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [cd044e7]
Page Load Metrics (1715 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32220731629336161
domContentLoaded14502083168616378
load14582105171517684
domInteractive226532105
backgroundConnect996352613
firstReactRender1596442813
getState58411178
initialActions01000
loadScripts9741487122713263
setupStore684212411
uiStartup167727962063312150
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Mrtenz
Mrtenz previously approved these changes Dec 20, 2024
@FrederikBolding FrederikBolding added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@FrederikBolding FrederikBolding added this pull request to the merge queue Dec 20, 2024
@FrederikBolding FrederikBolding removed this pull request from the merge queue due to a manual request Dec 20, 2024
@FrederikBolding FrederikBolding dismissed stale reviews from Mrtenz and david0xd via 2c88c7e December 20, 2024 16:07
@FrederikBolding FrederikBolding force-pushed the fb/use-break-word-for-text-wrapping branch from cd044e7 to 2c88c7e Compare December 20, 2024 16:07
@metamaskbot
Copy link
Collaborator

Builds ready [2c88c7e]
Page Load Metrics (1724 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint143620911732216104
domContentLoaded14162009168319593
load142320891724209101
domInteractive21276445426
backgroundConnect10102392914
firstReactRender1698493014
getState587252813
initialActions01000
loadScripts10431609127417182
setupStore687222512
uiStartup166928342095321154
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@FrederikBolding FrederikBolding added this pull request to the merge queue Dec 21, 2024
Merged via the queue into main with commit c91b4ee Dec 21, 2024
77 checks passed
@FrederikBolding FrederikBolding deleted the fb/use-break-word-for-text-wrapping branch December 21, 2024 09:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section with horizontal alignment crushes first element
4 participants