-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use break-word
for Snaps UI text wrapping
#29387
Merged
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamaskbot
added
team-snaps-platform
Snaps Platform team
INVALID-PR-TEMPLATE
PR's body doesn't match template
labels
Dec 20, 2024
david0xd
previously approved these changes
Dec 20, 2024
Builds ready [cd044e7]
Page Load Metrics (1715 ± 84 ms)
Bundle size diffs
|
Mrtenz
previously approved these changes
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 20, 2024
FrederikBolding
dismissed stale reviews from Mrtenz and david0xd
via
December 20, 2024 16:07
2c88c7e
FrederikBolding
force-pushed
the
fb/use-break-word-for-text-wrapping
branch
from
December 20, 2024 16:07
cd044e7
to
2c88c7e
Compare
david0xd
approved these changes
Dec 20, 2024
Builds ready [2c88c7e]
Page Load Metrics (1724 ± 101 ms)
Bundle size diffs
|
Mrtenz
approved these changes
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 20, 2024
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Dec 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-12.11.0
Issue or pull request that will be included in release 12.11.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
break-word
for Snaps UI text wrapping to prevent squishing of text inSection
among other components.Related issues
Fixes: MetaMask/snaps#2816
Screenshots/Recordings