Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SOL-80 transaction details #29323

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Dec 18, 2024

Description

This PR adds the new transaction details modal for the non-evm networks, BTC and SOL.

Screenshot 2024-12-18 at 14 42 18

Screen.Recording.2024-12-17.at.12.27.40.mov

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Didn't exist.

After

Screenshot 2024-12-18 at 14 42 18

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 18, 2024
@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 18, 2024
@zone-live zone-live added the team-sol PRs from the Solana snap team label Dec 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [fb3ab57]
Page Load Metrics (1626 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1475185016249144
domContentLoaded1467183616079043
load1475187616269546
domInteractive238637168
backgroundConnect86824178
firstReactRender1673372412
getState46011147
initialActions01000
loadScripts1045143312019244
setupStore66816199
uiStartup16822091186210349
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -1.55 KiB (-0.02%)
  • common: 339 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ad4a81c]
Page Load Metrics (1726 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15371938172710852
domContentLoaded15211871168510149
load15371934172610852
domInteractive26101492713
backgroundConnect8155413517
firstReactRender16167454019
getState591263014
initialActions00000
loadScripts1121139312708038
setupStore67114178
uiStartup174426182095278133

@metamaskbot
Copy link
Collaborator

Builds ready [9428075]
Page Load Metrics (1622 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1510186616338139
domContentLoaded1471177815997636
load1475185416228641
domInteractive17132533517
backgroundConnect777272010
firstReactRender16101533316
getState473172311
initialActions01000
loadScripts1082135411886632
setupStore67815199
uiStartup166625892019265127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-sol PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants