test: [POM] Migrate watch account tests #29314

chloeYue · 2024-12-18T10:49:56Z

Description

Created a new page class AccountDetailsModal. Previously, it was a part of AccountList. I think it's better to separate it and make it an independent class.
I also took the chance to improve the function addAccount and remove the origin addNewAccount. So now for creating ethereum, bitcoin, solana accounts, we use the same addAccount function with the account type as a parameter.
Migrate watch account e2e tests to Page Object Model
Created watchEoaAddress flow that can be reusable.

Related issues

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-18T10:50:10Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-12-18T14:06:19Z

Builds ready [f149e45]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1674 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	405	1851	1601	291	140
		domContentLoaded	1424	1811	1646	104	50
		load	1467	1871	1674	111	53
		domInteractive	24	58	31	8	4
		backgroundConnect	11	75	27	18	8
		firstReactRender	15	94	38	25	12
		getState	6	58	20	20	9
		initialActions	0	1	0	0	0
		loadScripts	1061	1395	1242	89	43
		setupStore	7	57	12	14	7
		uiStartup	1681	2390	1959	145	69

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-12-19T09:38:23Z

Builds ready [d125d81]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1897 ± 173 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1567	3218	1894	351	169
		domContentLoaded	1510	3157	1859	341	164
		load	1571	3268	1897	360	173
		domInteractive	24	263	56	52	25
		backgroundConnect	9	149	44	37	18
		firstReactRender	17	239	56	48	23
		getState	5	69	16	17	8
		initialActions	0	1	0	0	0
		loadScripts	1120	2558	1416	302	145
		setupStore	7	68	17	17	8
		uiStartup	1715	4115	2187	500	240

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

cmd-ob

LGTM! Nice work

metamaskbot · 2024-12-19T14:58:51Z

Builds ready [b7d2c81]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1970 ± 110 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1685	2698	1970	223	107
		domContentLoaded	1642	2655	1943	225	108
		load	1685	2703	1970	229	110
		domInteractive	25	155	61	30	15
		backgroundConnect	7	64	27	20	9
		firstReactRender	17	91	41	24	12
		getState	7	78	24	22	11
		initialActions	0	1	0	0	0
		loadScripts	1200	2137	1446	204	98
		setupStore	8	63	27	23	11
		uiStartup	1996	2899	2272	240	115

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 131 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

cmd-ob

LGTM

test/e2e/page-objects/flows/watch-account.flow.ts

test/e2e/page-objects/pages/account-list-page.ts

test/e2e/page-objects/pages/dialog/account-details-modal.ts

metamaskbot · 2024-12-20T10:32:53Z

Builds ready [ef2016b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1428 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1314	1826	1439	110	53
		domContentLoaded	1307	1818	1410	108	52
		load	1314	1827	1428	108	52
		domInteractive	22	99	37	20	9
		backgroundConnect	7	44	18	13	6
		firstReactRender	15	96	40	31	15
		getState	4	51	16	18	8
		initialActions	0	1	0	0	0
		loadScripts	959	1472	1050	108	52
		setupStore	6	67	12	17	8
		uiStartup	1485	2053	1726	190	91

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 131 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

chloeYue added 7 commits December 6, 2024 16:13

migrate tests

6c94475

migrate tests

f03db39

migrate tests

3faafa6

migrate tests

a545d07

Merge branch 'main' into migrate-watch-account-tests

907a89e

fix lint

3fc6a8e

fix

69e793c

chloeYue added the team-extension-platform label Dec 18, 2024

chloeYue requested a review from a team as a code owner December 18, 2024 10:49

chloeYue requested review from seaona and cmd-ob December 18, 2024 10:50

chloeYue marked this pull request as draft December 18, 2024 11:07

chloeYue added 2 commits December 18, 2024 12:33

fix test

478a34d

fix

f149e45

Merge branch 'main' into migrate-watch-account-tests

d125d81

chloeYue changed the title ~~test: Migrate watch account tests~~ test: [POM] Migrate watch account tests Dec 19, 2024

chloeYue marked this pull request as ready for review December 19, 2024 09:50

cmd-ob previously approved these changes Dec 19, 2024

View reviewed changes

chloeYue marked this pull request as draft December 19, 2024 12:48

Merge branch 'main' into migrate-watch-account-tests

75b9c6f

chloeYue dismissed cmd-ob’s stale review via 75b9c6f December 19, 2024 13:14

improve add account flow

b7d2c81

chloeYue marked this pull request as ready for review December 19, 2024 14:48

cmd-ob previously approved these changes Dec 20, 2024

View reviewed changes

seaona reviewed Dec 20, 2024

View reviewed changes

test/e2e/page-objects/flows/watch-account.flow.ts Outdated Show resolved Hide resolved

seaona reviewed Dec 20, 2024

View reviewed changes

test/e2e/page-objects/pages/account-list-page.ts Show resolved Hide resolved

seaona reviewed Dec 20, 2024

View reviewed changes

test/e2e/page-objects/pages/dialog/account-details-modal.ts Show resolved Hide resolved

address comment

ef2016b

chloeYue dismissed cmd-ob’s stale review via ef2016b December 20, 2024 09:45

seaona approved these changes Dec 20, 2024

View reviewed changes

cmd-ob approved these changes Dec 20, 2024

View reviewed changes

chloeYue added this pull request to the merge queue Dec 20, 2024

Merged via the queue into main with commit 356ad47 Dec 20, 2024
77 checks passed

chloeYue deleted the migrate-watch-account-tests branch December 20, 2024 11:15

github-actions bot locked and limited conversation to collaborators Dec 20, 2024

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [POM] Migrate watch account tests #29314

test: [POM] Migrate watch account tests #29314

chloeYue commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Dec 18, 2024

metamaskbot commented Dec 18, 2024

metamaskbot commented Dec 19, 2024

cmd-ob left a comment

metamaskbot commented Dec 19, 2024

cmd-ob left a comment

metamaskbot commented Dec 20, 2024

test: [POM] Migrate watch account tests #29314

test: [POM] Migrate watch account tests #29314

Conversation

chloeYue commented Dec 18, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 18, 2024

metamaskbot commented Dec 18, 2024

metamaskbot commented Dec 19, 2024

cmd-ob left a comment

Choose a reason for hiding this comment

metamaskbot commented Dec 19, 2024

cmd-ob left a comment

Choose a reason for hiding this comment

metamaskbot commented Dec 20, 2024

chloeYue commented Dec 18, 2024 •

edited

Loading