Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptotavares/improve confirmation re renders #29146

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cryptotavares
Copy link
Contributor

@cryptotavares cryptotavares commented Dec 12, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Dec 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [133e601]
Page Load Metrics (2017 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31123381923402193
domContentLoaded17312319198616479
load17472338201716077
domInteractive2411438209
backgroundConnect96030189
firstReactRender169423178
getState882291433216
initialActions01000
loadScripts13081889156715173
setupStore77912157
uiStartup198427542343220106
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 599 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@cryptotavares cryptotavares force-pushed the cryptotavares/improve-confirmation-re-renders branch from 133e601 to 7b24e67 Compare December 20, 2024 12:07
@metamaskbot
Copy link
Collaborator

Builds ready [7b24e67]
Page Load Metrics (1937 ± 284 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint148133121914545262
domContentLoaded146032921888545262
load147833721937592284
domInteractive15180625024
backgroundConnect7371568139
firstReactRender1697552613
getState55815157
initialActions02010
loadScripts109125791415441212
setupStore64818157
uiStartup162838802269684329
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 599 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants