Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Displaying multiple "You list" when multiple assets are being listed #28944

Closed
bschorchit opened this issue Dec 4, 2024 · 0 comments · Fixed by #29020
Closed

[Bug]: Displaying multiple "You list" when multiple assets are being listed #28944

bschorchit opened this issue Dec 4, 2024 · 0 comments · Fixed by #29020
Assignees
@jpuri
Labels
regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 release-12.10.1 Issue or pull request that will be included in release 12.10.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@bschorchit
Copy link

bschorchit commented Dec 4, 2024 •
edited
Loading

Describe the bug

We currently displaying multiple "You list" and "Spending cap" for multiple assets. We should be displaying the copy only once similar to how we do it for simulations.

Expected behavior

Displaying "You list" only once for the first asset - similar to how we do on simulations when multiple assets are being received or sent.

Screenshots/Recordings

image

Image

Steps to reproduce

  1. Go to test dapp
  2. Click on Malicious Seaport
  3. See the Estimated changes section

Error messages or log output

No response

Detection stage

During release testing

Version

12.9.0

Build type

None

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@bschorchit bschorchit added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team labels Dec 4, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Dec 4, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Dec 4, 2024
@metamaskbot metamaskbot added the regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 label Dec 4, 2024
@jpuri jpuri self-assigned this Dec 6, 2024
This was referenced Dec 9, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@jpuri
fix: Fix in label displayed for state change in signature decoding se…
717cd87 
…ction (#29020)

## **Description**

We currently displaying multiple "You list" and "Spending cap" for
multiple assets. We should be displaying the copy only once similar to
how we do it for simulations.

## **Related issues**

Fixes: #28944

## **Manual testing steps**

1. Submit a typed sign v4 request with multiple NFT listed
2. Check simulation section on page displayed

## **Screenshots/Recordings**
<img width="359" alt="Screenshot 2024-12-09 at 6 05 46 PM"
src="https://github.com/user-attachments/assets/d847f04b-be71-49c2-a3f3-77fdc23bdddd">

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 12, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Dec 12, 2024
@metamaskbot metamaskbot added the release-12.10.1 Issue or pull request that will be included in release 12.10.1 label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 release-12.10.1 Issue or pull request that will be included in release 12.10.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
3 participants
@jpuri @bschorchit @metamaskbot