-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable Ledger clear signing feature #28909
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
@SocketSecurity ignore npm/[email protected] |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
844163a
to
93d3a8c
Compare
93d3a8c
to
717c864
Compare
@metamaskbot update-policies |
Policy update failed. You can review the logs or retry the policy update here |
…ait for lib upgrade a release.
…patch to work before library upgrade.
ed517c9
to
aec3d12
Compare
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [32e5e57]
Page Load Metrics (1700 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Tested on local build using Ledger Nano X and Ledger Stax. Flows tested on the clear signing test dapp include:-
Also, regular flows tested on test-dapp include:-
|
Description
This PR enable the clear signing feature in metamask mobile.
Please refer to this feature requests for detail: https://github.com/MetaMask/accounts-planning/issues/544
Related issues
Fixes:
Manual testing steps
Test the clear signing using this dapp provided by ledger team:
https://clear-signing-tester.vercel.app/
When test in EIP712 sign message, please use polygon mainnet or ethereum mainnet.
sign transaction can use linea testnet.
Pre-merge author checklist
Pre-merge reviewer checklist