Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [Snaps E2E] Add test cases for signature confirmations redesign to signature insights snaps test #26691

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

bowensanders
Copy link
Contributor

@bowensanders bowensanders commented Aug 27, 2024

Description

This adds test cases for signature confirmations redesign to signature insights snaps test

Open in GitHub Codespaces

Related issues

Fixes: #26634

Manual testing steps

  1. Run test individually or check CI

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders self-assigned this Aug 27, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Aug 27, 2024
@bowensanders bowensanders added e2e-test End to end test for the MetaMask extension area-snaps labels Aug 27, 2024
Copy link

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (aea494d) to head (9f6f4e1).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26691   +/-   ##
========================================
  Coverage    70.09%   70.09%           
========================================
  Files         1413     1413           
  Lines        49255    49259    +4     
  Branches     13768    13770    +2     
========================================
+ Hits         34524    34527    +3     
- Misses       14731    14732    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowensanders bowensanders marked this pull request as ready for review August 27, 2024 22:30
@bowensanders bowensanders requested a review from a team as a code owner August 27, 2024 22:30
@metamaskbot
Copy link
Collaborator

Builds ready [9f6f4e1]
Page Load Metrics (86 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint872751184019
domContentLoaded47246814120
load56246863919
domInteractive10176373416
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit c2e9fc4 into develop Aug 28, 2024
78 checks passed
@FrederikBolding FrederikBolding deleted the bowen/sigins-new branch August 28, 2024 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 28, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-snaps e2e-test End to end test for the MetaMask extension release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: [Snaps E2E] Expand signature insights test to test on the redesigned confirmations
5 participants