Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable VNC over ssh #26106

Merged
merged 19 commits into from
Aug 30, 2024
Merged

ci: enable VNC over ssh #26106

merged 19 commits into from
Aug 30, 2024
+130 −57

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Jul 24, 2024 •
edited
Loading

Description

This PR makes it easier to SSH into CircleCI and use VNC.

See the new instructions here:
https://github.com/MetaMask/metamask-extension/blob/develop/docs/ssh-to-circleci.md

(This code and procedure were based on the documentation from CircleCI, which does not work as written https://circleci.com/docs/browser-testing/#interacting-with-the-browser-over-vnc)

Open in GitHub Codespaces

Related issues

Manual testing steps

To test this PR, you must "Rerun job with SSH" on branch circleci-vnc. When the PR is merged, it will work everywhere.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@HowardBraham HowardBraham self-assigned this Jul 24, 2024
@HowardBraham HowardBraham requested review from kumavis and a team as code owners July 24, 2024 21:58
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

greptile-apps[bot]

This comment was marked as outdated.

Sign in to view

@HowardBraham HowardBraham marked this pull request as draft July 24, 2024 22:08
@metamaskbot
Copy link
Collaborator

Builds ready [690fbc5]
Page Load Metrics (133 ± 139 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint68139952010
domContentLoaded96528189
load431389133289139
domInteractive96528189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham marked this pull request as ready for review July 25, 2024 00:01
greptile-apps[bot]

This comment was marked as outdated.

Sign in to view

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (9d668dd) to head (5c40f6f).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26106      +/-   ##
===========================================
- Coverage    70.13%   70.13%   -0.00%     
===========================================
  Files         1417     1417              
  Lines        49444    49444              
  Branches     13835    13835              
===========================================
- Hits         34676    34675       -1     
- Misses       14768    14769       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [f704e61]
Page Load Metrics (73 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint651391002311
domContentLoaded96130178
load39114732210
domInteractive96130178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

greptile-apps[bot]

This comment was marked as outdated.

Sign in to view

@metamaskbot
Copy link
Collaborator

Builds ready [4b34d91]
Page Load Metrics (162 ± 192 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint743011124622
domContentLoaded96025147
load451900162399192
domInteractive96025147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

ccharly
ccharly reviewed Jul 25, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/scripts/enable-vnc.sh Outdated Show resolved Hide resolved
.circleci/scripts/enable-vnc.sh Outdated Show resolved Hide resolved
.circleci/scripts/enable-vnc.sh Outdated Show resolved Hide resolved
docs/ssh-to-circleci.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.circleci/scripts/enable-vnc.sh Show resolved Hide resolved
seaona
seaona reviewed Aug 26, 2024
View reviewed changes
docs/ssh-to-circleci.md Outdated Show resolved Hide resolved
@HowardBraham HowardBraham removed the greptile Opt-in to the Greptile PR Review bot label Aug 29, 2024
@HowardBraham HowardBraham requested a review from seaona August 29, 2024 18:05
@metamaskbot
Copy link
Collaborator

Builds ready [68280c6]
Page Load Metrics (78 ± 13 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint801851082512
domContentLoaded52173742813
load58178782713
domInteractive188530178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue
Copy link
Contributor

LGTM ! I've followed the steps and it works on my machine (MAC)

Screen.Recording.2024-08-30.at.17.19.01.mov

chloeYue
chloeYue previously approved these changes Aug 30, 2024
View reviewed changes
hjetpoluru
hjetpoluru previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [aa6e393]
Page Load Metrics (1822 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23022031677493237
domContentLoaded16162098179514067
load16272207182215374
domInteractive166834136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Gudahtt
Gudahtt requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One suggestion on the CI config changes though, let me know what you think.

.circleci/config.yml Show resolved Hide resolved
@HowardBraham HowardBraham dismissed stale reviews from hjetpoluru and chloeYue via 5c40f6f August 30, 2024 16:56
Gudahtt
Gudahtt approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [5c40f6f]
Page Load Metrics (1804 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint20321811644502241
domContentLoaded15642120178114871
load15762130180415173
domInteractive177536157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review August 30, 2024 17:30
@HowardBraham HowardBraham merged commit c5cbdf0 into develop Aug 30, 2024
78 checks passed
@HowardBraham HowardBraham deleted the circleci-vnc branch August 30, 2024 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Aug 30, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
@HowardBraham HowardBraham added contributor experience An issue that impacts, or planned improvement to, the contributor experience. and removed team-contributor-experience labels Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@ccharly ccharly ccharly left review comments

@hjetpoluru hjetpoluru hjetpoluru approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@chloeYue chloeYue chloeYue left review comments

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@danroc danroc Awaiting requested review from danroc

@danjm danjm Awaiting requested review from danjm

@pedronfigueiredo pedronfigueiredo Awaiting requested review from pedronfigueiredo

@pnarayanaswamy pnarayanaswamy Awaiting requested review from pnarayanaswamy

@seaona seaona Awaiting requested review from seaona

Assignees

@HowardBraham HowardBraham

Labels
contributor experience An issue that impacts, or planned improvement to, the contributor experience. release-12.5.0 Issue or pull request that will be included in release 12.5.0
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@HowardBraham @metamaskbot @chloeYue @ccharly @Gudahtt @seaona @hjetpoluru @gauthierpetetin