chore: wire up bridge input actions [METABRIDGE-866] #25813

micaelae · 2024-07-12T22:31:47Z

Description

This change adds controller and redux methods for managing bridge page input fields (networks, src/dest chain, token, amounts)

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/METABRIDGE-866

Manual testing steps

Run extension locally with BRIDGE_USE_DEV_APIS=1
Click on Bridge button
Network tab should show requests for src tokens and topAssets

Screenshots/Recordings

Before

After

No visual changes

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

greptile-apps

PR Summary

This pull request introduces controller and Redux methods for managing bridge page input fields, enhancing the bridge functionality by allowing dynamic updates based on user input.

app/scripts/controllers/bridge.ts: Added methods to fetch and update tokens and top assets for selected networks.
ui/ducks/bridge/actions.ts: Introduced actions to set source and destination chains, ensuring Redux state sync.
ui/ducks/bridge/selectors.ts: Added new selectors for managing bridge state, leveraging reselect for memoization.
ui/hooks/bridge/useBridging.ts: Updated hook to use currentProviderConfig for bridging functionality.
test/e2e/tests/bridge/constants.ts: Added feature flags for allowed source and destination networks.

_{16 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

This pull request introduces controller and Redux methods for managing bridge page input fields, enhancing the bridge functionality by allowing dynamic updates based on user input.

app/scripts/controllers/bridge.ts: Added methods to fetch and update tokens and top assets for selected networks.
ui/ducks/bridge/actions.ts: Introduced actions to set source and destination chains, ensuring Redux state sync.
ui/ducks/bridge/selectors.ts: Added new selectors for managing bridge state, leveraging reselect for memoization.
ui/hooks/bridge/useBridging.ts: Updated hook to use currentProviderConfig for bridging functionality.
test/e2e/tests/bridge/constants.ts: Added feature flags for allowed source and destination networks.

_{25 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

This pull request introduces controller and Redux methods for managing bridge page input fields, enhancing the bridge functionality by allowing dynamic updates based on user input.

app/scripts/controllers/bridge.ts: Added methods to fetch and update tokens and top assets for selected networks.
test/e2e/tests/bridge/constants.ts: Introduced new feature flags for source and destination network allowlists.
test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json: Updated BridgeController state with new properties for tokens and top assets.
test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json: Added new properties to bridgeState for managing network and token data.
test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-background-state.json: Similar updates as the errors-after-init file, ensuring consistency in state management.

_{6 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

This pull request introduces controller and Redux methods for managing bridge page input fields, enhancing the bridge functionality by allowing dynamic updates based on user input.

test/e2e/tests/bridge/bridge-test-utils.ts: Added mock server response for the portfolio bridge endpoint to ensure proper handling in e2e tests.
test/e2e/tests/swap-send/swap-send-test-utils.ts: Introduced new utility functions to support Swap and Send page's end-to-end tests, enhancing test coverage and robustness.

_{2 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

metamaskbot · 2024-07-24T22:30:58Z

Builds ready [353ab3b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (134 ± 141 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	140	100	21	10
		domContentLoaded	9	60	26	13	6
		load	39	1413	134	294	141
		domInteractive	9	60	26	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -6.27 KiB (-0.19%)
ui: 9.22 KiB (0.12%)
common: 12.61 KiB (0.18%)

greptile-apps

PR Summary

(updates since last review)

This pull request introduces controller and Redux methods for managing bridge page input fields, enhancing the bridge functionality by allowing dynamic updates based on user input.

app/scripts/controllers/bridge.ts: Added methods for fetching and setting bridge feature flags, source/destination tokens, and top assets.
ui/ducks/bridge/actions.ts: Introduced new Redux actions for managing bridge input fields and interacting with the background controller.
ui/hooks/bridge/useBridging.ts: Enhanced the useBridging hook to handle bridge experience based on network and user settings.
test/e2e/tests/bridge/bridge-test-utils.ts: Added mock server response for the portfolio bridge endpoint to ensure proper handling in e2e tests.
ui/pages/bridge/index.tsx: Introduced the CrossChainSwap component to integrate the bridge feature into the application.

_{272 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-07-25T00:00:08Z

ui/ducks/bridge/actions.ts

+    const { chainId } = network;
+    if (!isProviderConfig(network)) {
+      // TODO add new network and set it as active using upsertNetworkConfiguration
+    } else if (isProviderConfig(network) && network.id) {


Style: Redundant check for isProviderConfig

greptile-apps

PR Summary

(updates since last review)

This pull request introduces controller and Redux methods for managing bridge page input fields, enhancing the bridge functionality by allowing dynamic updates based on user input.

app/scripts/controllers/bridge/bridge-controller.ts: Introduced a new BridgeController class to manage bridge state and actions.
ui/ducks/bridge/actions.ts: Added Redux actions for setting source and destination chains.
test/e2e/tests/bridge/bridge-test-utils.ts: Updated mock server setup for bridge API endpoints.
ui/pages/bridge/index.tsx: Integrated useBridging hook into CrossChainSwap component.
app/scripts/lib/setupSentry.js: Updated Sentry state with new bridge-related properties.

_{32 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-07-25T01:45:06Z

ui/ducks/bridge/actions.ts

+    const { chainId } = network;
+    if (!isProviderConfig(network)) {
+      // TODO add new network and set it as active using upsertNetworkConfiguration
+    } else if (isProviderConfig(network) && network.id) {


Style: Redundant check for isProviderConfig.

greptile-apps

PR Summary

(updates since last review)

This pull request introduces controller and Redux methods for managing bridge page input fields, enhancing the bridge functionality by allowing dynamic updates based on user input.

app/scripts/controllers/bridge/bridge-controller.ts: Added methods for selecting source and destination networks, fetching and setting top assets and tokens.
ui/ducks/bridge/actions.ts: Introduced new actions for setting source and destination chains.
test/e2e/tests/bridge/bridge-test-utils.ts: Updated mock server setup to handle new bridge API endpoints.
ui/pages/bridge/index.tsx: Integrated useBridging hook into CrossChainSwap component.
app/scripts/metamask-controller.js: Added new bridge input actions to the MetaMask controller.

_{29 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-07-25T02:00:22Z

ui/ducks/bridge/actions.ts

+    const { chainId } = network;
+    if (!isProviderConfig(network)) {
+      // TODO add new network and set it as active using upsertNetworkConfiguration
+    } else if (isProviderConfig(network) && network.id) {


Style: Redundant check for isProviderConfig.

metamaskbot · 2024-07-25T02:39:49Z

Builds ready [b6447a1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (84 ± 11 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	291	126	44	21
		domContentLoaded	11	64	35	15	7
		load	47	128	84	23	11
		domInteractive	11	64	35	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 7.06 KiB (0.21%)
ui: 9.25 KiB (0.12%)
common: 1.48 KiB (0.02%)

greptile-apps

PR Summary

(updates since last review)

This pull request introduces controller and Redux methods for managing bridge page input fields, enhancing the bridge functionality by allowing dynamic updates based on user input.

test/e2e/default-fixture.js: Updated bridgeFeatureFlags with network IDs '0x1', '0xa', and '0xe708'.
test/e2e/fixture-builder.js: Added withBridgeControllerDefaultState method to initialize BridgeController state.
test/e2e/tests/bridge/bridge-test-utils.ts: Added method to set default state for BridgeController and a TODO for future improvements.
test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-background-state.json: Added srcNetworkAllowlist and destNetworkAllowlist properties.
test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-ui-state.json: Updated bridgeFeatureFlags with specific network allowlists.

_{5 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

metamaskbot · 2024-07-25T03:55:24Z

Builds ready [e3d2cfd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (162 ± 165 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	300	120	51	25
		domContentLoaded	10	64	31	13	6
		load	41	1656	162	344	165
		domInteractive	10	64	31	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 7.1 KiB (0.21%)
ui: 9.25 KiB (0.12%)
common: 1.48 KiB (0.02%)

micaelae requested a review from a team as a code owner July 12, 2024 22:31

metamaskbot added the team-bridge label Jul 12, 2024

micaelae force-pushed the mb866-bridge-input-actions branch from 3a22d69 to 21b3f54 Compare July 12, 2024 22:54

micaelae changed the title ~~chore: wire up bridge input actions~~ chore: wire up bridge input actions [METABRIDGE-866] Jul 15, 2024

micaelae changed the base branch from mb867-bridge-feature-flagged-route to mb867-bridge-feature-flagged-route-e2e-test July 15, 2024 23:29

micaelae force-pushed the mb867-bridge-feature-flagged-route-e2e-test branch from 3662d50 to 235fd33 Compare July 15, 2024 23:30

micaelae force-pushed the mb866-bridge-input-actions branch from 21b3f54 to a74b678 Compare July 16, 2024 02:21

micaelae changed the base branch from mb867-bridge-feature-flagged-route-e2e-test to mb867-bridge-feature-flagged-route July 16, 2024 02:21

micaelae requested a review from a team as a code owner July 16, 2024 02:21

micaelae force-pushed the mb867-bridge-feature-flagged-route branch from 0b673a9 to eccc944 Compare July 18, 2024 20:55

micaelae requested a review from a team as a code owner July 18, 2024 20:55

micaelae changed the base branch from mb867-bridge-feature-flagged-route to mb867-bridge-feature-flagged-route-e2e-test July 18, 2024 22:24

micaelae force-pushed the mb867-bridge-feature-flagged-route-e2e-test branch from 3cfba29 to 7d640ae Compare July 18, 2024 22:27

micaelae force-pushed the mb866-bridge-input-actions branch from a74b678 to b41d339 Compare July 22, 2024 23:10

greptile-apps bot reviewed Jul 22, 2024

View reviewed changes

micaelae force-pushed the mb866-bridge-input-actions branch from b41d339 to 7eb09c0 Compare July 23, 2024 23:14

greptile-apps bot reviewed Jul 23, 2024

View reviewed changes

micaelae force-pushed the mb866-bridge-input-actions branch from 7eb09c0 to 3c05d7c Compare July 24, 2024 01:04

greptile-apps bot reviewed Jul 24, 2024

View reviewed changes

micaelae added 10 commits July 24, 2024 13:47

chore: fetch feature flags from account-overview page

c3182f8

chore: fetch feature flags from token-overview page

0ba8534

chore: use enums as bridge controller actions

d47bef3

chore: add new bridge route

f0af7fe

chore: create placeholder bridge page

9a8382f

chore: route to bridge page when FF is turned on

38aeb2f

fix: sentry e2e tests

c1a2ea9

fix: wallet-created integration test

f9cbaf8

fix: add type for event

ac2ff08

fix: early return

862e87a

greptile-apps bot reviewed Jul 25, 2024

View reviewed changes

micaelae added 2 commits July 24, 2024 17:31

refactor: reorganize bridge controller

b2e7e47

chore: upgrade BridgeController to BaseController V2

d035314

micaelae force-pushed the mb866-bridge-input-actions branch from 353ab3b to 85a352b Compare July 25, 2024 01:35

chore: read bridge chains from feature flags and add selectors

f155cae

micaelae changed the base branch from mb867-bridge-feature-flagged-route-e2e-test to mb866-bridge-controller-v2 July 25, 2024 01:41

micaelae added 6 commits July 24, 2024 18:44

chore: add bridge selected token and amount selectors/actions

95462ee

chore: add bridge SELECT_DEST_NETWORK action

fa361d6

chore: set bridge destTopAssets from swaps-api response

4523b21

chore: add bridge SELECT_SRC_NETWORK action

7e2b725

chore: set src network on Bridge page load

de1b189

fix: e2e tests

b6447a1

micaelae force-pushed the mb866-bridge-controller-v2 branch from f155cae to d035314 Compare July 25, 2024 01:46

micaelae force-pushed the mb866-bridge-input-actions branch from 85a352b to b6447a1 Compare July 25, 2024 01:46

greptile-apps bot reviewed Jul 25, 2024

View reviewed changes

fix: flaky sentry tests

e3d2cfd

greptile-apps bot reviewed Jul 25, 2024

View reviewed changes

micaelae force-pushed the mb866-bridge-controller-v2 branch 2 times, most recently from cfece3b to 23d035d Compare August 12, 2024 22:25

micaelae force-pushed the mb866-bridge-controller-v2 branch 4 times, most recently from 65c14a6 to 7d62780 Compare August 14, 2024 22:00

micaelae closed this Aug 14, 2024

micaelae deleted the mb866-bridge-input-actions branch August 14, 2024 22:09

github-actions bot locked and limited conversation to collaborators Aug 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: wire up bridge input actions [METABRIDGE-866] #25813

chore: wire up bridge input actions [METABRIDGE-866] #25813

micaelae commented Jul 12, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

metamaskbot commented Jul 24, 2024

greptile-apps bot left a comment

greptile-apps bot Jul 25, 2024

greptile-apps bot left a comment

greptile-apps bot Jul 25, 2024

greptile-apps bot left a comment

greptile-apps bot Jul 25, 2024

metamaskbot commented Jul 25, 2024

greptile-apps bot left a comment

metamaskbot commented Jul 25, 2024

chore: wire up bridge input actions [METABRIDGE-866] #25813

chore: wire up bridge input actions [METABRIDGE-866] #25813

Conversation

micaelae commented Jul 12, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

metamaskbot commented Jul 24, 2024

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jul 25, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jul 25, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jul 25, 2024

Choose a reason for hiding this comment

metamaskbot commented Jul 25, 2024

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

metamaskbot commented Jul 25, 2024

micaelae commented Jul 12, 2024 •

edited

Loading