Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CI on the l10n_crowdin_action branch #25770

Closed
9 tasks
vthomas13 opened this issue Jul 11, 2024 · 2 comments · Fixed by #25809
Closed
9 tasks

Disable CI on the l10n_crowdin_action branch #25770

vthomas13 opened this issue Jul 11, 2024 · 2 comments · Fixed by #25809
Assignees
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform

Comments

@vthomas13
Copy link
Contributor

vthomas13 commented Jul 11, 2024

What is this about?

A suggestion from @HowardBraham, we want to avoid running CI on this l10n_crowdin_action branch.
@Gudahtt suggests that we keep the lint step to catch issues with localized messages.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@HowardBraham
Copy link
Contributor

I think it would be easiest to implement the "just run the lint step" using GitHub Actions. You're going to encounter great complexities if you try to do it within CircleCI.

@HowardBraham
Copy link
Contributor

I made some changes that I documented in this PR comment: #25489 (comment)

I am not sure if this will already stop running CI on the l10n_crowdin_action branch, but it might. There does appear to be a PR though (#24889), so let's keep an eye on this.

@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants