-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Send and swap flow for unsupported networks #25107
Comments
This was addressed in a meeting yesterday: https://docs.google.com/document/d/1bfuJ3oRx3KHBtCZnySJjuTJ8r4FVVqDV3Eb-xxYJ4Zs/edit#heading=h.4mo58br3ahpy tl;dr: this is expected since the API isn't updated yet, but we expect it to be updated by mid-next week. Keeping this issue open until this actually happens |
Currently for unsupported networks we allow users to select destination token and then display 'No quotes available' or 'Error fetching quotes' message. Screen.Recording.2024-06-11.at.00.10.05.mov |
@BZahory Why not disable the dropdown if the network is unavailable? |
That's the current behavior. We previously assumed that all swap networks would be supported. Exact swap+send networks are now available here: https://swap.dev-api.cx.metamask.io/featureFlags; I'll make a PR to use these |
Missing release label release-12.0.0 on issue. Adding release label release-12.0.0 on issue, as issue is linked to PR #25474 which has this release label. |
The issue is present in the latest v12.0.0 build |
For Linea, another route is supported. Avalanche's unavailability is related to an API bug which @callumelvidge is investigating. Linea |
Describe the bug
In the context of the send+swap flow on unsupported networks, considering the substantial user base operating within these networks, introducing a notification system or potentially disabling this feature for networks beyond the mainnet and BNB might significantly improve the user experience.
Currently, when users on unsupported networks attempt to use the send+swap feature, they are allowed to select a destination token, only to encounter 'No quotes available' for the native token and 'Error fetching quotes' for other tokens.
A more user-friendly approach could involve defaulting to the regular send flow for non-supported networks (removing the option to select a destination token).
Expected behavior
Screenshots/Recordings
Steps to reproduce
Error messages or log output
No response
Version
develop branch
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: