Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Send and swap flow for unsupported networks #25107

Open
sleepytanya opened this issue Jun 6, 2024 · 13 comments · Fixed by #25474
Open

[Bug]: Send and swap flow for unsupported networks #25107

sleepytanya opened this issue Jun 6, 2024 · 13 comments · Fixed by #25474
Assignees
Labels
regression-beta-12.0.0 Regression bug that was found in beta in release 12.0.0 regression-beta-12.1.0 Regression bug that was found in beta in release 12.1.0 regression-RC-12.0.0 regression-RC-12.3.0 Regression bug that was found in release candidate (RC) for release 12.3.0 regression-RC-12.8.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 send-swap Sev3-low Low severity; minimal to no impact upon users team-wallet-ux type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

In the context of the send+swap flow on unsupported networks, considering the substantial user base operating within these networks, introducing a notification system or potentially disabling this feature for networks beyond the mainnet and BNB might significantly improve the user experience.
Currently, when users on unsupported networks attempt to use the send+swap feature, they are allowed to select a destination token, only to encounter 'No quotes available' for the native token and 'Error fetching quotes' for other tokens.
A more user-friendly approach could involve defaulting to the regular send flow for non-supported networks (removing the option to select a destination token).

Expected behavior

Screenshots/Recordings

Screenshot 2024-06-05 at 23 39 13 Screenshot 2024-06-05 at 23 40 47

Steps to reproduce

  1. Connect to unsupported network (e.g., Polygon, Arbitrum, etc.)
  2. Start send+swap flow
  3. Select native token as an origin token and any other token for the destination
  4. See 'No quotes available' message
  5. Select non-native token as an origin
  6. Select any token as a destination token
  7. 'Error fetching quotes' is shown

Error messages or log output

No response

Version

develop branch

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@BZahory
Copy link
Contributor

BZahory commented Jun 7, 2024

This was addressed in a meeting yesterday: https://docs.google.com/document/d/1bfuJ3oRx3KHBtCZnySJjuTJ8r4FVVqDV3Eb-xxYJ4Zs/edit#heading=h.4mo58br3ahpy

tl;dr: this is expected since the API isn't updated yet, but we expect it to be updated by mid-next week. Keeping this issue open until this actually happens

@BZahory BZahory self-assigned this Jun 7, 2024
@gauthierpetetin gauthierpetetin added the Sev3-low Low severity; minimal to no impact upon users label Jun 10, 2024
@sleepytanya
Copy link
Contributor Author

Currently for unsupported networks we allow users to select destination token and then display 'No quotes available' or 'Error fetching quotes' message.

Screen.Recording.2024-06-11.at.00.10.05.mov

@danjm
Copy link
Contributor

danjm commented Jun 20, 2024

@BZahory Why not disable the dropdown if the network is unavailable?

@BZahory
Copy link
Contributor

BZahory commented Jun 21, 2024

@BZahory Why not disable the dropdown if the network is unavailable?

That's the current behavior. We previously assumed that all swap networks would be supported. Exact swap+send networks are now available here: https://swap.dev-api.cx.metamask.io/featureFlags; I'll make a PR to use these

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jun 21, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jun 21, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
@metamaskbot metamaskbot added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 24, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.0.0 on issue. Adding release label release-12.0.0 on issue, as issue is linked to PR #25474 which has this release label.

@sleepytanya
Copy link
Contributor Author

sleepytanya commented Jun 29, 2024

The issue is present in the latest v12.0.0 build

Screenshot 2024-06-29 at 17 03 52

@sleepytanya sleepytanya reopened this Jun 29, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Jun 29, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by severity Jun 29, 2024
@sleepytanya
Copy link
Contributor Author

The issue is present in the v12.0.0. beta:

Screenshot 2024-07-15 at 22 04 31 Screenshot 2024-07-15 at 22 06 13

@sleepytanya sleepytanya added the regression-beta-12.0.0 Regression bug that was found in beta in release 12.0.0 label Jul 16, 2024
@sleepytanya
Copy link
Contributor Author

sleepytanya commented Jul 17, 2024

v12.0.0 branch with SWAPS_USE_DEV_APIS=true

Send+swap is not disabled on Avalanche and Linea, other popular networks seem to work as expected. Send+swap is disabled for Arbitrum and zkSync Era.

avalanceNoQoutes lineaNoQuotes

@BZahory
Copy link
Contributor

BZahory commented Jul 17, 2024

For Linea, another route is supported. Avalanche's unavailability is related to an API bug which @callumelvidge is investigating.

Linea

Screenshot 2024-07-17 at 4 05 03 PM

@sleepytanya
Copy link
Contributor Author

Production v12.1.0

Linea, Base and Optimism chains are not supported:

Screenshot 2024-08-09 at 18 10 32

@danjm danjm closed this as completed in f7b4771 Aug 15, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Aug 15, 2024
@sleepytanya sleepytanya reopened this Aug 23, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Aug 23, 2024
@sleepytanya
Copy link
Contributor Author

Beta 12.1.0 - Linea and Base:

Screenshot 2024-08-23 at 17 32 28 Screenshot 2024-08-23 at 17 38 21

@sleepytanya sleepytanya added the regression-beta-12.1.0 Regression bug that was found in beta in release 12.1.0 label Aug 23, 2024
@sleepytanya sleepytanya added the regression-RC-12.3.0 Regression bug that was found in release candidate (RC) for release 12.3.0 label Sep 12, 2024
@sleepytanya
Copy link
Contributor Author

sleepytanya commented Sep 12, 2024

RC 12.3.0 - 'No quotes' on Linea Mainnet:

noQuotesLinea.mov
Screenshot 2024-09-12 at 19 55 55

@sleepytanya
Copy link
Contributor Author

Present in the RC 12.8.0.

Quotes are not disabled on two unsupported networks, 'No quotes available' messages is displayed - Linea and zkSync Era:

Screenshot 2024-11-22 at 00 41 02 Screenshot 2024-11-22 at 00 41 34 Screenshot 2024-11-22 at 00 37 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-beta-12.0.0 Regression bug that was found in beta in release 12.0.0 regression-beta-12.1.0 Regression bug that was found in beta in release 12.1.0 regression-RC-12.0.0 regression-RC-12.3.0 Regression bug that was found in release candidate (RC) for release 12.3.0 regression-RC-12.8.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 send-swap Sev3-low Low severity; minimal to no impact upon users team-wallet-ux type-bug
Projects
Archived in project
Status: To be fixed
Development

Successfully merging a pull request may close this issue.

5 participants