Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Initiating a Send transaction from the Tokens tab occasionally requires two or more clicks on the 'Send' button to successfully start the transaction #24925

Closed
sleepytanya opened this issue May 30, 2024 · 6 comments
Labels
send-swap Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale team-wallet-ux type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

Initiating a Send transaction from the Tokens tab, specifically when selecting a token, occasionally requires two or more clicks on the 'Send' button to successfully start the transaction.

Expected behavior

Screenshots/Recordings

Chrome:

https://jam.dev/c/b04375a9-b789-4c5b-807e-262b353f4149

Firefox:

doubleClickTokenTab.mov

Steps to reproduce

  1. Go to Tokens tab
  2. Click any token
  3. Click 'Send'
  4. Notice that sometimes 2 or 3 click required to start the transaction

Error messages or log output

Warning: Failed prop type: The prop `accountName` is marked as required in `AssetBreadcrumb`, but its value is `undefined`.
    in AssetBreadcrumb (created by AssetNavigation)
    in AssetNavigation (created by NativeAsset)
    in NativeAsset (created by Asset)
    in div (created by Asset)
    in Asset (created by Context.Consumer)
    in Route (created by Authenticated)
    in Authenticated (created by ConnectFunction)
    in ConnectFunction (created by Routes)
    in Switch (created by Routes)
    in div (created by ForwardRef)
    in ForwardRef (created by Routes)
    in div (created by Routes)
    in Routes (created by ConnectFunction)
    in ConnectFunction (created by Context.Consumer)
    in withRouter(Connect(Routes)) (created by Index)
    in MetamaskNotificationsProvider (created by Index)
    in CurrencyRateProvider (created by Index)
    in LegacyI18nProvider (created by Index)
    in I18nProvider (created by Index)
    in LegacyMetaMetricsProvider (created by Index)
    in MetaMetricsProvider (created by Index)
    in Router (created by HashRouter)
    in HashRouter (created by Index)
    in Provider (created by Index)
    in Index backend.js:2045
    overrideMethod backend.js:2045
    printWarning checkPropTypes.js:20
    checkPropTypes checkPropTypes.js:83
    React 2
    AssetNavigation asset-navigation.js:9
    React 8
    unstable_runWithPriority scheduler.development.js:697
    React 26
    startApp index.js:213
    launchMetamaskUi index.js:75
    handleResponse metaRPCClientFactory.js:99
    emit events.js:153
    addChunk _stream_readable.js:279
    readableAddChunk _stream_readable.js:262
    push _stream_readable.js:228
    _write ObjectMultiplex.js:70
    doWrite _stream_writable.js:390
    writeOrBuffer _stream_writable.js:381
    write _stream_writable.js:302
    ondata readable.js:662
    emit events.js:153
    addChunk readable.js:278
    readableAddChunk readable.js:255
    push readable.js:201
    _onMessage index.js:30
    PortDuplexStream index.js:12


Warning: Failed prop type: The prop `accountName` is marked as required in `AssetNavigation`, but its value is `undefined`.
    in AssetNavigation (created by NativeAsset)
    in NativeAsset (created by Asset)
    in div (created by Asset)
    in Asset (created by Context.Consumer)
    in Route (created by Authenticated)
    in Authenticated (created by ConnectFunction)
    in ConnectFunction (created by Routes)
    in Switch (created by Routes)
    in div (created by ForwardRef)
    in ForwardRef (created by Routes)
    in div (created by Routes)
    in Routes (created by ConnectFunction)
    in ConnectFunction (created by Context.Consumer)
    in withRouter(Connect(Routes)) (created by Index)
    in MetamaskNotificationsProvider (created by Index)
    in CurrencyRateProvider (created by Index)
    in LegacyI18nProvider (created by Index)
    in I18nProvider (created by Index)
    in LegacyMetaMetricsProvider (created by Index)
    in MetaMetricsProvider (created by Index)
    in Router (created by HashRouter)
    in HashRouter (created by Index)
    in Provider (created by Index)
    in Index backend.js:2045
    overrideMethod backend.js:2045
    printWarning checkPropTypes.js:20
    checkPropTypes checkPropTypes.js:83
    React 2
    NativeAsset native-asset.js:35
    React 8
    unstable_runWithPriority scheduler.development.js:697
    React 26
    startApp index.js:213
    launchMetamaskUi index.js:75
    handleResponse metaRPCClientFactory.js:99
    emit events.js:153
    addChunk _stream_readable.js:279
    readableAddChunk _stream_readable.js:262
    push _stream_readable.js:228
    _write ObjectMultiplex.js:70
    doWrite _stream_writable.js:390
    writeOrBuffer _stream_writable.js:381
    write _stream_writable.js:302
    ondata readable.js:662
    emit events.js:153
    addChunk readable.js:278
    readableAddChunk readable.js:255
    push readable.js:201
    _onMessage index.js:30
    PortDuplexStream index.js:12

Version

dev build

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

dev build 4c64f44

Severity

No response

@sleepytanya
Copy link
Contributor Author

Also present on develop:

doubleClick.mov

@gauthierpetetin gauthierpetetin added the Sev3-low Low severity; minimal to no impact upon users label Jun 3, 2024
@sleepytanya
Copy link
Contributor Author

The issue is still present on the latest build Slack discussion link:

https://jam.dev/c/3c7e9c6d-5177-41a5-8be3-58cd1a01bc39

@BZahory
Copy link
Contributor

BZahory commented Jun 7, 2024

Holding off on this one for now since it's seems to be related to the broader getTokenStandardAndDetails issues

Copy link
Contributor

github-actions bot commented Sep 5, 2024

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Sep 5, 2024
Copy link
Contributor

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Oct 20, 2024
@desi
Copy link
Contributor

desi commented Dec 18, 2024

I no longer see this issue, tested on RC 12.10.0. Leaving as closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-swap Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale team-wallet-ux type-bug
Projects
Archived in project
Development

No branches or pull requests

5 participants
@desi @gauthierpetetin @BZahory @sleepytanya and others