Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Swap is no longer working when Smart Transaction is turned ON #23373

Closed
davibroc opened this issue Mar 7, 2024 · 1 comment · Fixed by #23425
Closed

[Bug]: Swap is no longer working when Smart Transaction is turned ON #23373

davibroc opened this issue Mar 7, 2024 · 1 comment · Fixed by #23425
Assignees
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-11.12.0 release-11.12.0 Issue or pull request that will be included in release 11.12.0 release-11.14.0 Issue or pull request that will be included in release 11.14.0 release-blocker This bug is blocking the next release team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@davibroc
Copy link
Contributor

davibroc commented Mar 7, 2024

Describe the bug

When Smart Transaction is turned ON, Swap is no longer working

From the initial look
TransactionController.approveTransactionsWithSameNonce expects a chainId inside each transaction, which is missing now. It can be added to transactions in ui/ducks/swaps/swaps.js in the

The problem doesn't happen if Smart Transaction is OFF or in production

Expected behavior

Swap is able complete when Smart Transcation is ON

Screenshots/Recordings

Swap_STX.mov

image (8)

Steps to reproduce

  1. Go to Swap
  2. Turn Smart Transaction ON
  3. Get a quote ETH->WETH
  4. Click on Swap
  5. Notice that the screen gets stuck on Preparing Swap

Error messages or log output

signAndSendSwapsSmartTransaction error (Error#1)

The number NaN cannot be converted to a BigInt because it is not an integer

Version

develop

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Mar 7, 2024
@davibroc davibroc added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Mar 7, 2024
@sleepytanya
Copy link
Contributor

sleepytanya commented Mar 9, 2024

Can confirm the same behavior on v.11.12.0, builds.

@matthewwalsh0 matthewwalsh0 added the release-blocker This bug is blocking the next release label Mar 12, 2024
@chloeYue chloeYue added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Mar 12, 2024
@metamaskbot metamaskbot added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Mar 12, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Mar 12, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 12, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 9, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-11.12.0 release-11.12.0 Issue or pull request that will be included in release 11.12.0 release-11.14.0 Issue or pull request that will be included in release 11.14.0 release-blocker This bug is blocking the next release team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants