-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flow to report false positive for blockaid #20856
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
11f239c
to
e76a939
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #20856 +/- ##
===========================================
- Coverage 68.64% 68.64% -0.00%
===========================================
Files 1016 1016
Lines 40758 40763 +5
Branches 10885 10885
===========================================
+ Hits 27977 27980 +3
- Misses 12781 12783 +2
☔ View full report in Codecov by Sentry. |
Builds ready [f5b061b]
Page Load Metrics (1530 ± 70 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Looks good, fix the CI failures. |
ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js
Outdated
Show resolved
Hide resolved
ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js
Outdated
Show resolved
Hide resolved
ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js
Outdated
Show resolved
Hide resolved
ui/pages/confirm-transaction-base/confirm-transaction-base.component.js
Outdated
Show resolved
Hide resolved
ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some more comments and suggestions. Is there are related issue ticket for this work? If so, can we add it to the description?
ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the suggestions and updates! LGTM!
Builds ready [37b21fc]
Page Load Metrics (1629 ± 95 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [ca092be]
Page Load Metrics (1635 ± 47 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…rected metric property
05294a5
ca092be
to
05294a5
Compare
Builds ready [260bb19]
Page Load Metrics (825 ± 355 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Explanation
We should allow users and developers to report false positives for the security provider warnings.
Tasks
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.