Get infuraBlocked from network state #20822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
reviewed
Sep 11, 2023
|
@metamaskbot update-policies |
|
Policy update failed. You can review the logs or retry the policy update here |
jiexi
commented
Sep 11, 2023
|
@metamaskbot update-policies |
|
Policies updated |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20822 +/- ##
===========================================
- Coverage 68.35% 68.34% -0.02%
===========================================
Files 1007 1007
Lines 40261 40254 -7
Branches 10766 10761 -5
===========================================
- Hits 27519 27508 -11
- Misses 12742 12746 +4
☔ View full report in Codecov by Sentry. |
Builds ready [f0e8e6e]
Page Load Metrics (1744 ± 121 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [cd7d8e6]
Page Load Metrics (1498 ± 37 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
adonesky1
reviewed
Sep 19, 2023
adonesky1
previously approved these changes
Sep 19, 2023
adonesky1
previously approved these changes
Sep 20, 2023
Builds ready [2d13a1d]
Page Load Metrics (1591 ± 88 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
14 tasks
adonesky1
previously approved these changes
Sep 21, 2023
|
@metamaskbot update-policies |
|
Policies updated |
adonesky1
previously approved these changes
Sep 21, 2023
Builds ready [888a247]
Page Load Metrics (1709 ± 76 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [888a247]
Page Load Metrics (1709 ± 76 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [888a247]
Page Load Metrics (1709 ± 76 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [3b998b6]
Page Load Metrics (1624 ± 61 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [dc5436a]
Page Load Metrics (1672 ± 60 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
adonesky1
approved these changes
Sep 22, 2023
Builds ready [623a52e]
Page Load Metrics (1602 ± 49 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
shanejonas
approved these changes
Sep 22, 2023
Builds ready [14a02e1]
Page Load Metrics (1845 ± 86 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
metamaskbot
added
the
release-11.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, infuraBlocked is managed via the PreferencesController through the
NetworkController:infuraIsBlockedandNetworkController:infuraIsUnblockedevents. As part of multichain work, we want to move away from a globally selected network. This PR removesstate.metamask.infuraBlockedand checksstate.metamask.networksMetadatafor network status instead. This still checks the currently the state for the selected network only though.Explanation
Screenshots/Screencaps
Before
After
Manual Testing Steps
Not super easy to test manually as you will need to use a VPN to connect from a location where infura is blocked or some how catch and modify the initial wallet rpc request to return a blocked error. You should see the infura blocked popup on the main wallet homepage when you have selected an infura RPC while connecting from a blocked location
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.