Version v11.1.0 RC #20752
Merged
Version v11.1.0 RC #20752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added ipfs toggle * added placeholder valur * fixed snapshot * updated tests * updated spec file * hide input if toggle is disabled * updated e2e tests for nft image * fixed view-ercc-1155 spec * updated e2e tests for nfts * added ipfs toggle modal * updated UI for ipfs * updated tests * updated classname * added placeholder image * lint fix * removed prop ipfsEnabled and used with selector * fixed ui for ipfs toggle * updated test * updated test to handle cases * nit fix * ensure default image height match nft image
* Fix ipfs-ens-resolution.spec.js E2E intermittent failure * Wait for URL change instead of large delay
* fix(action): default branch is develop, not main * fix(action): add missing documentation
Co-authored-by: Mark Stacey <[email protected]>
* Replaced with new checkbox in ConnectedAccountsPermissions * removed a typo * fixed linting issue * Small updates to styles --------- Co-authored-by: George Marshall <[email protected]>
* migrating AvatarAccount to TS * updates * reverting changes to diameter * suggested changes * adding explicit types for AvatarAccountDiameter * updating documentation * Some small updates to types --------- Co-authored-by: georgewrmarshall <[email protected]>
* Replaced ActionableMessage Instances in edit-gas * Updated BannerAlert className * Changed errorKey to errorMessage * Removing CSS and restoring local key --------- Co-authored-by: georgewrmarshall <[email protected]>
* replacing constants * updating ButtonLink component * Updates to responsive typography * lint fixes * snapshot updates --------- Co-authored-by: georgewrmarshall <[email protected]>
* Update ModalOverlay to use TS Box version * fix jest error * lint error fix * Fix lint errors and improve ModalOverlay's TypeScript typings * Some small updates to story and docs --------- Co-authored-by: georgewrmarshall <[email protected]>
* Replaces SEVERITIES const with Severity enum in BannerAlert * Replaced SEVERITIES with Severity in banner-alert.constants.js * Used BANNER_ALERT_SEVERITIES instead of SEVERITIES in banner-alert.stories.js * Updated README for usage of Severity instead of SEVERITIES * Updates to stories and docs link --------- Co-authored-by: Brad Decker <[email protected]> Co-authored-by: georgewrmarshall <[email protected]>
…ed (#20345) * Fix migration 88 to handle the case where chainId keys can be undefined * Add migration 91 to delete network configurations that have no chainId * Lint fix * Update migration number * Update migration 91 description * Update version numbers in 091.test.js * Fix 088.test.ts typescript problem * Fix 088.test.ts typescript problem * Update app/scripts/migrations/091.ts Co-authored-by: Mark Stacey <[email protected]> * Change app/scripts/migrations/091.test.js to typescript * clone oldstorage for test result comparisons in 091.test.js * Lint fix * Add missing test case --------- Co-authored-by: Mark Stacey <[email protected]>
* migration of HeaderBase to use TS Box version * migration of HeaderBase to use TS Box version * update snapshot * fix lint error * Some small updates to types and removing deprecated storyook functions --------- Co-authored-by: georgewrmarshall <[email protected]>
* securityAlert: fix settings copy * securityAlert: fix settings copy - update snapshop
* updated tooltip for token-list-item * updated snapshot
* allow `SnapController` to call `SnapsRegistry:update` * call `SnapController:updateBlockedSnaps` on extension startup * only check if at least one snap is installed
* deprecate opensea security alerts check Signedoff-by: Olusegun Akintayo <[email protected]> set metrics to [] Signed-off-by: Olusegun Akintayo <[email protected]> fix jest tests Signed-off-by: Olusegun Akintayo <[email protected]> Remove sec provider spec Signed-off-by: Olusegun Akintayo <[email protected]> lint fix Signed-off-by: Olusegun Akintayo <[email protected]> What's new for blockaid...with placeholder texts Signed-off-by: Olusegun Akintayo <[email protected]> i18n Signed-off-by: Olusegun Akintayo <[email protected]> lint fixes Rebase to develop Add image to whatsnew blockaid. Signed-off-by: Olusegun Akintayo <[email protected]> Fixed i18n Fixed snapshot for ui/pages/settings/experimental-tab/experimental-tab.test.js Signed-off-by: Olusegun Akintayo <[email protected]> Fix i18n messages Signed-off-by: Olusegun Akintayo <[email protected]> lint fixes Signed-off-by: Olusegun Akintayo <[email protected]> Add unit tests Lint fixes use new image that works for both dark and light mode 22 is taken Signed-off-by: Olusegun Akintayo <[email protected]> * comment out blockaid Signed-off-by: Olusegun Akintayo <[email protected]> * rever change in builds.yml Signed-off-by: Olusegun Akintayo <[email protected]> * reverted changes in test/e2e/tests/security-provider.spec.js * fix unit test Signed-off-by: Olusegun Akintayo <[email protected]> --------- Signed-off-by: Olusegun Akintayo <[email protected]>
* updated ipfs toggle copy * removed unused entries
* Add link to buy more ETH if insufficient gas * Fix lint error * Use native currency per network * Use localized msg for buy more gas * Add the word "more" * Fix smart tx not showing msg * Pull out not enough balance into own component * Add story for not enough balance * Fix btn text not being aligned with rest of text * Move inline style to class, remove empty classname * Update ui/pages/swaps/prepare-swap-page/not-enough-balance.stories.tsx Co-authored-by: George Marshall <[email protected]> * Update ui/pages/swaps/prepare-swap-page/index.scss Co-authored-by: Nidhi Kumari <[email protected]> * Remove line * Move BannerAlert back into review-quote and use BannerAlert props * Remove unused CSS --------- Co-authored-by: George Marshall <[email protected]> Co-authored-by: Nidhi Kumari <[email protected]>
* bump @metamask/network-controller from v10.3.0 to v11.0.0 * add lavamoat policy files * fix * tweak
Master sync PR following v10.34.2
…y settings (#20278) * move opensea api and nft settings to security tab * DS techdebt; experimental tab * rerouting the NFT tab enable autodetect to setting * reverting vscode settings and preferences.js * Rerouting NFT tab autodetect setting banner link * resolving settingsRef collision
* added test for image * nit fix
The `metamaskbot` comment on each PR now includes links to MMI builds. This relates to #20782
MMI builds are now published alongside stable releases, in the same manner as Flask. They will be included in future GitHub release pages, and tracked using separate git tags. Sentry sourcemaps are uploaded for them during the release process as well. Closes #20782
|
Conducted hardware testing against commit f134493 running Mac Ventura 13.5.2. Majority of testing was with Chrome 117.0.5938.88 (Official Build), unless noted Firefox and in that case was 117.0.1 (64 bit). Observations in 11.1 RC were all able to be reproduced in v11.0 and v10.35.1, and will be reported outside of the RC. |
* Bump LavaMoat and SES * Use latest versions * Use [email protected] * Update LavaMoat policies * Unpin LavaMoat versions * update lavamoat build policy * Fix LavaMoat patch * Update LavaMoat policies --------- Co-authored-by: Frederik Bolding <[email protected]> Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: legobt <[email protected]>
* updated placeholder for erc-1155 image * removed code duplication * updated collections * updated snapshot * updated stories * updated condition from includes to startsWith * Use startsWith instead of includes --------- Co-authored-by: Danica Shen <[email protected]> Co-authored-by: David Walsh <[email protected]> Co-authored-by: chloeYue <[email protected]>
* Fix copy and add 3rd party API links * Extract uppercase logic into a variable * Fix snapshot tests * fix e2e test * fix lint error
…ts on the same client (#20973) * fix incoming tx filtering * tweak filtering * tweak filtering * tweak filtering * tweak filtering * refactor filtering on activity list * simplify solution * update comment * reintroduce filtering and address comments * fix linting errors * fix test * fix comment * wip * wip
danjm
force-pushed
the
Version-v11.1.0
branch
from
a205636 to
e2968e0
Compare
This PR is to show the NFT Default image when the Image is hosted on OpenSea but display Media is off Further Context [slack message ](https://consensys.slack.com/archives/C029JG63136/p1695634003818569?thread_ts=1693992718.193729&cid=C029JG63136) 1. When IPFS is enabled: - If NFT image relies on IPFS storage show the NFT - If NFT image relies on OpenSea and OpenSea toggle is ON, show NFT - If NFT image relies on OpenSea and OpenSea toggle is OFF, show Default Image without the show Button. - If both the toggles are on, show NFT 2. When IPFS is disabled: - If the NFT image relies on IPFS storage, show Default Image with the show Button. - If the NFT image relies on OpenSea and OpenSea toggle is ON, show NFT - If the NFT image relies on OpenSea and OpenSea toggle is OFF, show Default Image without the show Button _Fixes [https://github.com/MetaMask/MetaMask-planning/issues/1330](#https://github.com/MetaMask/MetaMask-planning/issues/1330) - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [ ] I’ve included tests if applicable. - [ ] I’ve documented any added code. - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Dan J Miller <[email protected]> Co-authored-by: Brad Decker <[email protected]>
Builds ready [7b7ab8f]
Page Load Metrics (1657 ± 50 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
albertolive
approved these changes
Sep 27, 2023
|
@SocketSecurity ignore-all |
chloeYue
approved these changes
Sep 27, 2023
brad-decker
approved these changes
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.