Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore necessity of custom Filter Integration for Sentry #20174

Closed
brad-decker opened this issue Jul 25, 2023 · 1 comment
Closed

Explore necessity of custom Filter Integration for Sentry #20174

brad-decker opened this issue Jul 25, 2023 · 1 comment
Labels
area-Sentry error reporting to sentry type-enhancement

Comments

@brad-decker
Copy link
Contributor

In #20132 we added onto the 'beforeSend' method to return null if the participateInMetaMetrics flag is not true. In a new PR we could check to see if this is sufficient and if the Filter integration that we run serves other purposes other than filtering out events based on the participateInMetaMetrics flag. Its possible we could eliminate some code from the code base.

@brad-decker
Copy link
Contributor Author

@Gudahtt pointed out on #20132 that this would be a revert to a change made to preventing the Dupe filter from filtering out events that occur after the participateInMetaMetrics flag changes. If you fire an error while opted out then opt in and fire the same error the new error will be ignored because Dedupe is unaware of the effects of beforeSend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Sentry error reporting to sentry type-enhancement
Projects
None yet
Development

No branches or pull requests

1 participant