-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all fa-angle/fa-chevron icons with equivalent Icon
components
#17448
Comments
Icon
componentsIcon
components
Hey, |
Hi @spiritanand, thanks for asking! There is a PR open for this issue #17455 that @imdebamrita is working on. I'll assign it to them. I'll be creating more similar issues today so keep an eye for those 🙏 |
@imdebamrita could you comment on this ticket so I can assign it to you please? |
@georgewrmarshall how can I contribute to some logical code in metamask? |
@spiritanand here is a similar issue #17526 you could take on if you're interested! Please comment your interest so I can assign you the issue in the comments section like you did for this issue 🙏 |
hey @georgewrmarshall is anyone working on this issue? can i jump right in? |
hey @georgewrmarshall, is this upforgrabs? if yes can i work on this? |
@georgewrmarshall Are there some other similar issues I can work on? |
Hey @samyabrata-maji, answered you in #17670. Thanks! |
Hey @georgewrmarshall are there any similar issues on which I can work? |
Closing this as it's completed in 17787 |
Description
In an effort to replace all font-awesome icons with the new
Icon
component it would be great to replace allfa-angle-[direction]
,fa-chevron-[direction]
and<IconCaret[direction]
components theIcon
equivalentOne way to find all the
fa-angle-
icons would be to search "fa-angle-"Similar with
fa-chevron-
Same with
<IconCaret
Technical Details
fa-angle-up
font awesome icons with<Icon name={ICON_NAMES.ARROW_UP} />
fa-angle-right
font awesome icons with<Icon name={ICON_NAMES.ARROW_RIGHT} />
fa-angle-down
font awesome icons with<Icon name={ICON_NAMES.ARROW_DOWN} />
fa-angle-left
font awesome icons with<Icon name={ICON_NAMES.ARROW_LEFT} />
fa-chevron-right
font awesome icons with<Icon name={ICON_NAMES.ARROW_RIGHT} />
fa-chevron-left
font awesome icons with<Icon name={ICON_NAMES.ARROW_LEFT} />
<IconCaretLeft
font awesome icons with<Icon name={ICON_NAMES.ARROW_LEFT} />
<IconCaretRight
font awesome icons with<Icon name={ICON_NAMES.ARROW_RIGHT} />
<IconCaretUp
font awesome icons with<Icon name={ICON_NAMES.ARROW_UP} />
<IconCaretDown
font awesome icons with<Icon name={ICON_NAMES.ARROW_DOWN} />
Acceptance Criteria
fa-angle-[direction]
have been replaced with theirIcon
component equivalentfa-chevron-[direction]
have been replaced with theirIcon
component equivalent<IconCaret[direction]
have been replaced with theirIcon
component equivalentReferences
The text was updated successfully, but these errors were encountered: