Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all fa-angle/fa-chevron icons with equivalent Icon components #17448

Closed
georgewrmarshall opened this issue Jan 26, 2023 · 12 comments
Closed
Assignees
Labels
area-UI Relating to the user interface. good first issue Good for newcomers team-design-system All issues relating to design system in Extension team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Jan 26, 2023

Description

In an effort to replace all font-awesome icons with the new Icon component it would be great to replace all fa-angle-[direction], fa-chevron-[direction] and <IconCaret[direction] components the Icon equivalent

One way to find all the fa-angle- icons would be to search "fa-angle-"

Screenshot 2023-01-26 at 3 29 26 PM

Similar with fa-chevron-

Screenshot 2023-01-26 at 3 42 25 PM

Same with <IconCaret

Screenshot 2023-01-26 at 4 17 50 PM

Technical Details

  • Replace all fa-angle-up font awesome icons with <Icon name={ICON_NAMES.ARROW_UP} />
  • Replace all fa-angle-right font awesome icons with <Icon name={ICON_NAMES.ARROW_RIGHT} />
  • Replace all fa-angle-down font awesome icons with <Icon name={ICON_NAMES.ARROW_DOWN} />
  • Replace all fa-angle-left font awesome icons with <Icon name={ICON_NAMES.ARROW_LEFT} />
  • Replace all fa-chevron-right font awesome icons with <Icon name={ICON_NAMES.ARROW_RIGHT} />
  • Replace all fa-chevron-left font awesome icons with <Icon name={ICON_NAMES.ARROW_LEFT} />
  • Replace all <IconCaretLeft font awesome icons with <Icon name={ICON_NAMES.ARROW_LEFT} />
  • Replace all <IconCaretRight font awesome icons with <Icon name={ICON_NAMES.ARROW_RIGHT} />
  • Replace all <IconCaretUp font awesome icons with <Icon name={ICON_NAMES.ARROW_UP} />
  • Replace all <IconCaretDown font awesome icons with <Icon name={ICON_NAMES.ARROW_DOWN} />

Acceptance Criteria

  • All fa-angle-[direction] have been replaced with their Icon component equivalent
  • All fa-chevron-[direction] have been replaced with their Icon component equivalent
  • All <IconCaret[direction] have been replaced with their Icon component equivalent
  • PR includes screenshot of before and after of all instances can do it in the code comments if it makes more sense

References

@georgewrmarshall georgewrmarshall added good first issue Good for newcomers area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension labels Jan 26, 2023
@georgewrmarshall georgewrmarshall changed the title Replace all fa-angle icons with equivalent Icon components Replace all fa-angle/fa-chevron icons with equivalent Icon components Jan 26, 2023
imdebamrita added a commit to imdebamrita/metamask-extension that referenced this issue Jan 27, 2023
@spiritanand
Copy link
Contributor

Hey,
Can I work on this issue?

@kevinghim kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jan 30, 2023
@georgewrmarshall
Copy link
Contributor Author

Hi @spiritanand, thanks for asking! There is a PR open for this issue #17455 that @imdebamrita is working on. I'll assign it to them. I'll be creating more similar issues today so keep an eye for those 🙏

@georgewrmarshall
Copy link
Contributor Author

@imdebamrita could you comment on this ticket so I can assign it to you please?

@spiritanand
Copy link
Contributor

@georgewrmarshall how can I contribute to some logical code in metamask?

@georgewrmarshall
Copy link
Contributor Author

georgewrmarshall commented Jan 31, 2023

@spiritanand here is a similar issue #17526 you could take on if you're interested! Please comment your interest so I can assign you the issue in the comments section like you did for this issue 🙏

#17526

@Aathirajan
Copy link

hey @georgewrmarshall is anyone working on this issue? can i jump right in?

@sammaji
Copy link

sammaji commented Feb 13, 2023

hey @georgewrmarshall, is this upforgrabs? if yes can i work on this?

@georgewrmarshall
Copy link
Contributor Author

Looks like @darkwing has scooped this up #17668

@sammaji
Copy link

sammaji commented Feb 14, 2023

@georgewrmarshall Are there some other similar issues I can work on?

@georgewrmarshall
Copy link
Contributor Author

Hey @samyabrata-maji, answered you in #17670. Thanks!

@sambhavgupta0705
Copy link

Hey @georgewrmarshall are there any similar issues on which I can work?

@NidhiKJha
Copy link
Member

NidhiKJha commented Mar 13, 2023

Closing this as it's completed in 17787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. good first issue Good for newcomers team-design-system All issues relating to design system in Extension team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

No branches or pull requests

8 participants