error from contract returned as string not as object

[MonarthS]

Error thrown from contract returned as string, so can not parse specific error:

contract error

• as you can see, actual error message from contract is Unauthorized Access!, but metamask returned it as string(message + json object).

other errors

• other metamask errors are returned as object.

Expected behavior

• Should return error as object same as other metamask errors.

Browser details (please complete the following information):

• OS: OS X
• Browser: Chrome Version 95.0.4638.69 (Official Build) (x86_64)
• MetaMask Version: 10.4.1

[BelfordZ]

@MonarthS Im having trouble reproducing this issue. From what I can tell, there is a related issue though - errors returned from smart contracts are returned as nested errors the error.message has the real json-rpc error inside of it.

Any chance you could let me know if you are still running into this, and if so, how i might reproduce the output from the screenshot provided.

Thank you!

[BelfordZ]

here is some notes from trying out different errors in the playground, which uses only the json rpc api:

1. errors can come from the promise api, or from the event api. Both are have somewhat different formats (varying uses of error.data, in some cases the errors are nested inside of the error.message, which is probably the case you are running into)
2. A large subset of the possible errors returned from metamask largely depend on the underlying network/rpcUrl that metamask is conencted to. For example, the errors I get from ganache are different than the ones I get from using rinkby, same as if I use an entirely different ethereum-like network such as celo.

---

Just for Here is some examples of errors you can get from using ganache & playground:

1. bad nonce for the account set manually by the user
   

2. wrong method name for request permissions. (note the data section, and well formed message)
   

3. signature denied by the user:
   

4. intentionally failing contract tx:
   

5. intentionally failing contract call (eth_call instead eth_sendTransaction)
   

[BelfordZ]

followup questions:

1. What is sending {value: { error... } } ? are we wrapping with value?
2. When the error returned from rpc api is not formatted according to expectation, we could return a better result than wrapping the object in a string

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

[github-actions]

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.