From d67a5c7c87e4b6820a0185cef619a6ca695a8944 Mon Sep 17 00:00:00 2001 From: digiwand <20778143+digiwand@users.noreply.github.com> Date: Wed, 18 Dec 2024 21:01:43 +0700 Subject: [PATCH] feat: swap punycode with original version in add_ethereumChain Network URL display --- app/_locales/de/messages.json | 4 ---- app/_locales/el/messages.json | 4 ---- app/_locales/en/messages.json | 2 +- app/_locales/es/messages.json | 4 ---- app/_locales/fr/messages.json | 4 ---- app/_locales/hi/messages.json | 4 ---- app/_locales/id/messages.json | 4 ---- app/_locales/ja/messages.json | 4 ---- app/_locales/ko/messages.json | 4 ---- app/_locales/pt/messages.json | 4 ---- app/_locales/ru/messages.json | 4 ---- app/_locales/tl/messages.json | 4 ---- app/_locales/tr/messages.json | 4 ---- app/_locales/vi/messages.json | 4 ---- app/_locales/zh_CN/messages.json | 4 ---- .../confirmation/templates/add-ethereum-chain.js | 2 +- 16 files changed, 2 insertions(+), 58 deletions(-) diff --git a/app/_locales/de/messages.json b/app/_locales/de/messages.json index a738b56b0fe0..7594930998e5 100644 --- a/app/_locales/de/messages.json +++ b/app/_locales/de/messages.json @@ -3186,10 +3186,6 @@ "networkURLDefinition": { "message": "Die URL, die für den Zugriff auf dieses Netzwerk verwendet wird." }, - "networkUrlErrorWarning": { - "message": "Angreifer imitieren manchmal Websites, indem sie kleine Änderungen an der Adresse der Website vornehmen. Vergewissern Sie sich, dass Sie mit der beabsichtigten Website interagieren, bevor Sie fortfahren. Punycode-Version: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Netzwerke" }, diff --git a/app/_locales/el/messages.json b/app/_locales/el/messages.json index 7992443a500a..1de35a8e3f72 100644 --- a/app/_locales/el/messages.json +++ b/app/_locales/el/messages.json @@ -3186,10 +3186,6 @@ "networkURLDefinition": { "message": "Η διεύθυνση URL που χρησιμοποιείται για την πρόσβαση σε αυτό το δίκτυο." }, - "networkUrlErrorWarning": { - "message": "Οι εισβολείς μερικές φορές αντιγράφουν ιστότοπους κάνοντας μικρές αλλαγές στη διεύθυνση του ιστότοπου. Βεβαιωθείτε ότι αλληλεπιδράτε με τον ιστότοπο που θέλετε πριν συνεχίσετε. Έκδοση Punycode: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Δίκτυα" }, diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json index 3bfd303e5dd0..2d6e33612c0f 100644 --- a/app/_locales/en/messages.json +++ b/app/_locales/en/messages.json @@ -3376,7 +3376,7 @@ "message": "The URL used to access this network." }, "networkUrlErrorWarning": { - "message": "Attackers sometimes mimic sites by making small changes to the site address. Make sure you're interacting with the intended site before you continue. Punycode version: $1", + "message": "Attackers sometimes mimic sites by making small changes to the site address. Make sure you're interacting with the intended site before you continue. We replaced the original version with its punycode encoded form. Original version: $1", "description": "$1 replaced by RPC URL for network" }, "networks": { diff --git a/app/_locales/es/messages.json b/app/_locales/es/messages.json index 2475977d0794..b9c547b30612 100644 --- a/app/_locales/es/messages.json +++ b/app/_locales/es/messages.json @@ -3186,10 +3186,6 @@ "networkURLDefinition": { "message": "La dirección URL que se utilizó para acceder a esta red." }, - "networkUrlErrorWarning": { - "message": "A veces, los atacantes imitan sitios web haciendo pequeños cambios en la dirección del sitio. Asegúrese de estar interactuando con el sitio deseado antes de continuar. Versión de Punycode: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Redes" }, diff --git a/app/_locales/fr/messages.json b/app/_locales/fr/messages.json index abe83f8ea900..e007a4b92b63 100644 --- a/app/_locales/fr/messages.json +++ b/app/_locales/fr/messages.json @@ -3186,10 +3186,6 @@ "networkURLDefinition": { "message": "L’URL utilisée pour accéder à ce réseau." }, - "networkUrlErrorWarning": { - "message": "Les pirates informatiques imitent parfois les sites en modifiant légèrement l’adresse du site. Assurez-vous que vous interagissez avec le site voulu avant de continuer. Version Punycode : $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Réseaux" }, diff --git a/app/_locales/hi/messages.json b/app/_locales/hi/messages.json index 4eaf54f8b012..bfd3824a49f2 100644 --- a/app/_locales/hi/messages.json +++ b/app/_locales/hi/messages.json @@ -3186,10 +3186,6 @@ "networkURLDefinition": { "message": "इस नेटवर्क तक पहुंचने के लिए इस्तेमाल किया जाने वाला URL।" }, - "networkUrlErrorWarning": { - "message": "हमला करने वाले कभी-कभी साइट के एड्रेस में छोटे-छोटे बदलाव करके साइटों की नकल करते हैं। जारी रखने से पहले सुनिश्चित करें कि आप इच्छित साइट के साथ इंटरैक्ट कर रहे हैं। पुनीकोड ​​वर्शन: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "नेटवर्क" }, diff --git a/app/_locales/id/messages.json b/app/_locales/id/messages.json index c93bd496ac12..e1544be7a57f 100644 --- a/app/_locales/id/messages.json +++ b/app/_locales/id/messages.json @@ -3186,10 +3186,6 @@ "networkURLDefinition": { "message": "URL yang digunakan untuk mengakses jaringan ini." }, - "networkUrlErrorWarning": { - "message": "Penyerang terkadang meniru situs dengan membuat perubahan kecil pada alamat situs. Pastikan Anda berinteraksi dengan situs yang dituju sebelum melanjutkan. Versi Punycode: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Jaringan" }, diff --git a/app/_locales/ja/messages.json b/app/_locales/ja/messages.json index 24a2f60314cd..5c30e72bf6da 100644 --- a/app/_locales/ja/messages.json +++ b/app/_locales/ja/messages.json @@ -3187,10 +3187,6 @@ "networkURLDefinition": { "message": "このネットワークへのアクセスに使用されるURLです。" }, - "networkUrlErrorWarning": { - "message": "攻撃者は、サイトのアドレスに若干の変更を加えてサイトを模倣することがあります。続行する前に、意図したサイトとやり取りしていることを確認してください。Punycodeバージョン: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "ネットワーク" }, diff --git a/app/_locales/ko/messages.json b/app/_locales/ko/messages.json index c261f74b4b5c..c187b5bf1fb8 100644 --- a/app/_locales/ko/messages.json +++ b/app/_locales/ko/messages.json @@ -3187,10 +3187,6 @@ "networkURLDefinition": { "message": "이 네트워크에 액세스하는 데 사용되는 URL입니다." }, - "networkUrlErrorWarning": { - "message": "공격자는 사이트 주소를 약간 변경하여 유사 사이트를 만들기도 합니다. 계속하기 전에 정상적인 사이트와 상호 작용하고 있는지 확인하세요. Punycode 버전: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "네트워크" }, diff --git a/app/_locales/pt/messages.json b/app/_locales/pt/messages.json index 5a1389a0d4d6..fec860078966 100644 --- a/app/_locales/pt/messages.json +++ b/app/_locales/pt/messages.json @@ -3187,10 +3187,6 @@ "networkURLDefinition": { "message": "O URL usado para acessar essa rede." }, - "networkUrlErrorWarning": { - "message": "Golpistas às vezes imitam os sites fazendo pequenas alterações em seus endereços. Certifique-se de estar interagindo com o site correto antes de continuar. Versão Punycode: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Redes" }, diff --git a/app/_locales/ru/messages.json b/app/_locales/ru/messages.json index 37a672ec798a..8c618cac6249 100644 --- a/app/_locales/ru/messages.json +++ b/app/_locales/ru/messages.json @@ -3186,10 +3186,6 @@ "networkURLDefinition": { "message": "URL, используемый для доступа к этой сети." }, - "networkUrlErrorWarning": { - "message": "Злоумышленники иногда имитируют сайты, внося небольшие изменения в адрес сайта. Прежде чем продолжить, убедитесь, что вы взаимодействуете с нужным сайтом. Версия пьюникода: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Сети" }, diff --git a/app/_locales/tl/messages.json b/app/_locales/tl/messages.json index 20b318456d77..3c522c58962a 100644 --- a/app/_locales/tl/messages.json +++ b/app/_locales/tl/messages.json @@ -3187,10 +3187,6 @@ "networkURLDefinition": { "message": "Ang URL ay ginamit upang ma-access ang network na ito." }, - "networkUrlErrorWarning": { - "message": "Minsan ginagaya ng mga umaatake ang mga site sa pamamagitan ng paggawa ng maliliit na pagbabago sa address ng site. Tiyaking nakikipag-ugnayan ka sa nilalayong site bago ka magpatuloy. Bersyon ng Punycode: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Mga Network" }, diff --git a/app/_locales/tr/messages.json b/app/_locales/tr/messages.json index 470bb934f74b..e03d4e746e42 100644 --- a/app/_locales/tr/messages.json +++ b/app/_locales/tr/messages.json @@ -3187,10 +3187,6 @@ "networkURLDefinition": { "message": "Bu ağa erişim sağlamak için kullanılan URL adresi." }, - "networkUrlErrorWarning": { - "message": "Saldırganlar bazen site adresinde küçük değişiklikler yaparak siteleri taklit edebilir. Devam etmeden önce planladığınız site ile etkileşim kurduğunuzdan emin olun. Punycode sürümü: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Ağlar" }, diff --git a/app/_locales/vi/messages.json b/app/_locales/vi/messages.json index d331ab42b9b5..c182e4617ee8 100644 --- a/app/_locales/vi/messages.json +++ b/app/_locales/vi/messages.json @@ -3187,10 +3187,6 @@ "networkURLDefinition": { "message": "URL dùng để truy cập vào mạng này." }, - "networkUrlErrorWarning": { - "message": "Kẻ tấn công đôi khi bắt chước các trang web bằng cách thực hiện những thay đổi nhỏ trong địa chỉ trang web. Đảm bảo bạn đang tương tác với trang web dự định trước khi tiếp tục. Phiên bản Punycode: $1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "Mạng" }, diff --git a/app/_locales/zh_CN/messages.json b/app/_locales/zh_CN/messages.json index 52941dcc24f9..bd08516cc156 100644 --- a/app/_locales/zh_CN/messages.json +++ b/app/_locales/zh_CN/messages.json @@ -3187,10 +3187,6 @@ "networkURLDefinition": { "message": "用于访问此网络的 URL。" }, - "networkUrlErrorWarning": { - "message": "攻击者有时会通过对网站地址进行细微更改来模仿网站。在继续操作之前，请确保您是与目标网站进行交互。Punycode 版本：$1", - "description": "$1 replaced by RPC URL for network" - }, "networks": { "message": "网络" }, diff --git a/ui/pages/confirmations/confirmation/templates/add-ethereum-chain.js b/ui/pages/confirmations/confirmation/templates/add-ethereum-chain.js index 4f08f7e73337..6c837176ea6d 100644 --- a/ui/pages/confirmations/confirmation/templates/add-ethereum-chain.js +++ b/ui/pages/confirmations/confirmation/templates/add-ethereum-chain.js @@ -224,7 +224,7 @@ function getValues(pendingApproval, t, actions, history, data) { const warningNetworkUrlMsg = isValidASCIIURL(customRpcUrl) ? undefined - : t('networkUrlErrorWarning', [normalizedRpcUrl]); + : t('networkUrlErrorWarning', [customRpcUrl]); let title; if (originIsMetaMask) {