From b963edc86bf3aa52f9835154db31131896042b25 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Wed, 27 Nov 2024 20:23:52 -0330 Subject: [PATCH] chore: Bump `@metamask/message-manager` to v11 (#28758) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** The `@metamask/message-manager` package has been updated from v10 to v11. The only breaking change is the removal of exports previously used by the signature controller which are no longer used. Changelog: https://github.com/MetaMask/core/blob/main/packages/message-manager/CHANGELOG.md#1100 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28758?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot --- lavamoat/browserify/beta/policy.json | 19 +--------------- lavamoat/browserify/flask/policy.json | 19 +--------------- lavamoat/browserify/main/policy.json | 19 +--------------- lavamoat/browserify/mmi/policy.json | 19 +--------------- package.json | 3 +-- yarn.lock | 32 +++++++++++++-------------- 6 files changed, 21 insertions(+), 90 deletions(-) diff --git a/lavamoat/browserify/beta/policy.json b/lavamoat/browserify/beta/policy.json index 2904dba53751..500ea98a3d4c 100644 --- a/lavamoat/browserify/beta/policy.json +++ b/lavamoat/browserify/beta/policy.json @@ -1653,29 +1653,12 @@ "packages": { "@metamask/base-controller": true, "@metamask/controller-utils": true, - "@metamask/eth-sig-util": true, - "@metamask/message-manager>@metamask/utils": true, - "@metamask/message-manager>jsonschema": true, + "@metamask/utils": true, "browserify>buffer": true, "uuid": true, "webpack>events": true } }, - "@metamask/message-manager>@metamask/utils": { - "globals": { - "TextDecoder": true, - "TextEncoder": true - }, - "packages": { - "@metamask/utils>@metamask/superstruct": true, - "@metamask/utils>@scure/base": true, - "@metamask/utils>pony-cause": true, - "@noble/hashes": true, - "browserify>buffer": true, - "nock>debug": true, - "semver": true - } - }, "@metamask/message-manager>jsonschema": { "packages": { "browserify>url": true diff --git a/lavamoat/browserify/flask/policy.json b/lavamoat/browserify/flask/policy.json index 2904dba53751..500ea98a3d4c 100644 --- a/lavamoat/browserify/flask/policy.json +++ b/lavamoat/browserify/flask/policy.json @@ -1653,29 +1653,12 @@ "packages": { "@metamask/base-controller": true, "@metamask/controller-utils": true, - "@metamask/eth-sig-util": true, - "@metamask/message-manager>@metamask/utils": true, - "@metamask/message-manager>jsonschema": true, + "@metamask/utils": true, "browserify>buffer": true, "uuid": true, "webpack>events": true } }, - "@metamask/message-manager>@metamask/utils": { - "globals": { - "TextDecoder": true, - "TextEncoder": true - }, - "packages": { - "@metamask/utils>@metamask/superstruct": true, - "@metamask/utils>@scure/base": true, - "@metamask/utils>pony-cause": true, - "@noble/hashes": true, - "browserify>buffer": true, - "nock>debug": true, - "semver": true - } - }, "@metamask/message-manager>jsonschema": { "packages": { "browserify>url": true diff --git a/lavamoat/browserify/main/policy.json b/lavamoat/browserify/main/policy.json index 2904dba53751..500ea98a3d4c 100644 --- a/lavamoat/browserify/main/policy.json +++ b/lavamoat/browserify/main/policy.json @@ -1653,29 +1653,12 @@ "packages": { "@metamask/base-controller": true, "@metamask/controller-utils": true, - "@metamask/eth-sig-util": true, - "@metamask/message-manager>@metamask/utils": true, - "@metamask/message-manager>jsonschema": true, + "@metamask/utils": true, "browserify>buffer": true, "uuid": true, "webpack>events": true } }, - "@metamask/message-manager>@metamask/utils": { - "globals": { - "TextDecoder": true, - "TextEncoder": true - }, - "packages": { - "@metamask/utils>@metamask/superstruct": true, - "@metamask/utils>@scure/base": true, - "@metamask/utils>pony-cause": true, - "@noble/hashes": true, - "browserify>buffer": true, - "nock>debug": true, - "semver": true - } - }, "@metamask/message-manager>jsonschema": { "packages": { "browserify>url": true diff --git a/lavamoat/browserify/mmi/policy.json b/lavamoat/browserify/mmi/policy.json index 24ba9d2bff4b..e0f35bdf1b7b 100644 --- a/lavamoat/browserify/mmi/policy.json +++ b/lavamoat/browserify/mmi/policy.json @@ -1745,29 +1745,12 @@ "packages": { "@metamask/base-controller": true, "@metamask/controller-utils": true, - "@metamask/eth-sig-util": true, - "@metamask/message-manager>@metamask/utils": true, - "@metamask/message-manager>jsonschema": true, + "@metamask/utils": true, "browserify>buffer": true, "uuid": true, "webpack>events": true } }, - "@metamask/message-manager>@metamask/utils": { - "globals": { - "TextDecoder": true, - "TextEncoder": true - }, - "packages": { - "@metamask/utils>@metamask/superstruct": true, - "@metamask/utils>@scure/base": true, - "@metamask/utils>pony-cause": true, - "@noble/hashes": true, - "browserify>buffer": true, - "nock>debug": true, - "semver": true - } - }, "@metamask/message-manager>jsonschema": { "packages": { "browserify>url": true diff --git a/package.json b/package.json index caa0f091ef6b..0f69fabd4941 100644 --- a/package.json +++ b/package.json @@ -240,7 +240,6 @@ "@expo/config/glob": "^10.3.10", "@expo/config-plugins/glob": "^10.3.10", "@solana/web3.js/rpc-websockets": "^8.0.1", - "@metamask/message-manager": "^10.1.0", "@metamask/nonce-tracker@npm:^5.0.0": "patch:@metamask/nonce-tracker@npm%3A5.0.0#~/.yarn/patches/@metamask-nonce-tracker-npm-5.0.0-d81478218e.patch", "@metamask/network-controller@npm:^17.0.0": "patch:@metamask/network-controller@npm%3A21.0.0#~/.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch", "@metamask/network-controller@npm:^19.0.0": "patch:@metamask/network-controller@npm%3A21.0.0#~/.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch", @@ -317,7 +316,7 @@ "@metamask/keyring-controller": "^19.0.0", "@metamask/logging-controller": "^6.0.0", "@metamask/logo": "^3.1.2", - "@metamask/message-manager": "^10.1.0", + "@metamask/message-manager": "^11.0.0", "@metamask/message-signing-snap": "^0.4.0", "@metamask/metamask-eth-abis": "^3.1.1", "@metamask/name-controller": "^8.0.0", diff --git a/yarn.lock b/yarn.lock index 20f79c1457d9..660eabd98155 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5797,23 +5797,23 @@ __metadata: linkType: hard "@metamask/keyring-controller@npm:^17.1.0": - version: 17.2.2 - resolution: "@metamask/keyring-controller@npm:17.2.2" + version: 17.3.1 + resolution: "@metamask/keyring-controller@npm:17.3.1" dependencies: "@ethereumjs/util": "npm:^8.1.0" "@keystonehq/metamask-airgapped-keyring": "npm:^0.14.1" - "@metamask/base-controller": "npm:^7.0.1" + "@metamask/base-controller": "npm:^7.0.2" "@metamask/browser-passworder": "npm:^4.3.0" "@metamask/eth-hd-keyring": "npm:^7.0.4" - "@metamask/eth-sig-util": "npm:^7.0.1" + "@metamask/eth-sig-util": "npm:^8.0.0" "@metamask/eth-simple-keyring": "npm:^6.0.5" "@metamask/keyring-api": "npm:^8.1.3" - "@metamask/message-manager": "npm:^10.1.1" - "@metamask/utils": "npm:^9.1.0" + "@metamask/message-manager": "npm:^11.0.1" + "@metamask/utils": "npm:^10.0.0" async-mutex: "npm:^0.5.0" ethereumjs-wallet: "npm:^1.0.1" immer: "npm:^9.0.6" - checksum: 10/3c3cec4c813de78c889c38b9a5f6201929743544a28c9e734bbf57a3774e3c2bc9432bb3cefa69bb7ed3580933898329c8a5e374c21c07ea204ee19bf094c8ff + checksum: 10/167608de873566a28f0fa8f6e88ee2f57809f29289fcd7787f16589f42f9fa076a73a45b36cc1e0bbcc0f6d20b40a44c1d1f9b86a2eaebe15428d8b9cb46c753 languageName: node linkType: hard @@ -5859,18 +5859,18 @@ __metadata: languageName: node linkType: hard -"@metamask/message-manager@npm:^10.1.0": - version: 10.1.0 - resolution: "@metamask/message-manager@npm:10.1.0" +"@metamask/message-manager@npm:^11.0.0, @metamask/message-manager@npm:^11.0.1": + version: 11.0.1 + resolution: "@metamask/message-manager@npm:11.0.1" dependencies: - "@metamask/base-controller": "npm:^7.0.0" - "@metamask/controller-utils": "npm:^11.2.0" - "@metamask/eth-sig-util": "npm:^7.0.1" - "@metamask/utils": "npm:^9.1.0" + "@metamask/base-controller": "npm:^7.0.2" + "@metamask/controller-utils": "npm:^11.4.2" + "@metamask/eth-sig-util": "npm:^8.0.0" + "@metamask/utils": "npm:^10.0.0" "@types/uuid": "npm:^8.3.0" jsonschema: "npm:^1.2.4" uuid: "npm:^8.3.2" - checksum: 10/aaf62d595b74ec723faf490f1152e8edda394e4572ebc162c604fccd393073d8c655915190f5196245022c5e112f017227e00a93b330271feb440bb865ce5420 + checksum: 10/a63a79bbddfd06ca729ca1ca2a1f2fd9b5c930efaaee1d8bc077f7352ae058ff7f99c9b6bdfd7f7d3df4328a3c3606922d961d45c8d39c2b7afb4a893ec1cf6b languageName: node linkType: hard @@ -26760,7 +26760,7 @@ __metadata: "@metamask/keyring-controller": "npm:^19.0.0" "@metamask/logging-controller": "npm:^6.0.0" "@metamask/logo": "npm:^3.1.2" - "@metamask/message-manager": "npm:^10.1.0" + "@metamask/message-manager": "npm:^11.0.0" "@metamask/message-signing-snap": "npm:^0.4.0" "@metamask/metamask-eth-abis": "npm:^3.1.1" "@metamask/name-controller": "npm:^8.0.0"