From b018c81fb51c796294da8ea0f4ec618b30793981 Mon Sep 17 00:00:00 2001 From: Jyoti Puri Date: Wed, 18 Dec 2024 14:59:35 +0530 Subject: [PATCH 1/2] fix: Fix icon alignment in signature pages message section (#29284) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** Fix icon alignment in signature pages message section. ## **Related issues** Fixes: https://github.com/MetaMask/metamask-extension/issues/28793 ## **Manual testing steps** 1. Go to test dapp 2. Submit permit 3. Check expand and copy icons position in message section ## **Screenshots/Recordings** Screenshot 2024-12-17 at 9 06 53 PM ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- .../info/row/__snapshots__/row.test.tsx.snap | 2 +- ui/components/app/confirm/info/row/row.tsx | 3 +-- .../info/__snapshots__/info.test.tsx.snap | 6 ++--- .../__snapshots__/approve.test.tsx.snap | 2 +- .../__snapshots__/personal-sign.test.tsx.snap | 8 +++---- .../__snapshots__/siwe-sign.test.tsx.snap | 8 +++---- .../transaction-data.test.tsx.snap | 8 +++---- .../__snapshots__/typed-sign-v1.test.tsx.snap | 4 ++-- .../__snapshots__/typed-sign.test.tsx.snap | 14 ++++++------ .../__snapshots__/confirm.test.tsx.snap | 22 +++++++++---------- 10 files changed, 38 insertions(+), 39 deletions(-) diff --git a/ui/components/app/confirm/info/row/__snapshots__/row.test.tsx.snap b/ui/components/app/confirm/info/row/__snapshots__/row.test.tsx.snap index a6a52806b2cf..5014d138a242 100644 --- a/ui/components/app/confirm/info/row/__snapshots__/row.test.tsx.snap +++ b/ui/components/app/confirm/info/row/__snapshots__/row.test.tsx.snap @@ -37,7 +37,7 @@ exports[`ConfirmInfoRow should match snapshot when copy is enabled 1`] = `