From b2e46e654224d4ad1a2ff3ca9ffa6a12bd33f691 Mon Sep 17 00:00:00 2001 From: Sylva Elendu Date: Wed, 20 Sep 2023 12:49:42 +0100 Subject: [PATCH] unneeded code --- app/_locales/en/messages.json | 3 ++- ...ecurity-provider-banner-alert.test.js.snap | 2 +- .../security-provider-banner-alert.js | 10 ++-------- .../transaction-alerts/transaction-alerts.js | 19 +------------------ 4 files changed, 6 insertions(+), 28 deletions(-) diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json index 302468a59a8b..6bb49c2e7d2c 100644 --- a/app/_locales/en/messages.json +++ b/app/_locales/en/messages.json @@ -4142,7 +4142,8 @@ "message": "Some networks may pose security and/or privacy risks. Understand the risks before adding & using a network." }, "somethingDoesntLookRight": { - "message": "Something doesn't look right? $1" + "message": "Something doesn't look right? $1", + "description": "A false positive message for users to contact support. $1 is a link to the support page." }, "somethingIsWrong": { "message": "Something's gone wrong. Try reloading the page." diff --git a/ui/components/app/security-provider-banner-alert/__snapshots__/security-provider-banner-alert.test.js.snap b/ui/components/app/security-provider-banner-alert/__snapshots__/security-provider-banner-alert.test.js.snap index ad92f2bc8eaf..ff549ac5dc51 100644 --- a/ui/components/app/security-provider-banner-alert/__snapshots__/security-provider-banner-alert.test.js.snap +++ b/ui/components/app/security-provider-banner-alert/__snapshots__/security-provider-banner-alert.test.js.snap @@ -58,7 +58,7 @@ exports[`Security Provider Banner Alert should match snapshot 1`] = `

[somethingDoesntLookRight]

diff --git a/ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js b/ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js index b73a641554e7..87b0a42194a2 100644 --- a/ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js +++ b/ui/components/app/security-provider-banner-alert/security-provider-banner-alert.js @@ -51,13 +51,7 @@ function SecurityProviderBannerAlert({ {provider && ( <> - + {t('somethingDoesntLookRight', [ - getKnownMethodData(state, txParams?.data), - ); ///: END:ONLY_INCLUDE_IN ///: BEGIN:ONLY_INCLUDE_IN(blockaid) @@ -63,12 +52,6 @@ const TransactionAlerts = ({ event: MetaMetricsEventName.ExternalLinkClicked, properties: { action: 'Confirm Screen', - legacy_event: true, - recipientKnown: null, - functionType: - 'confirm' || - getMethodName(methodData.name) || - TransactionType.contractInteraction, origin: txData?.origin, external_link_clicked: true, security_alert_support_link: ZENDESK_URLS.SUPPORT_URL,