From 7dc6362a70a3e7ab1de406bfdcbae7ad4d2c68be Mon Sep 17 00:00:00 2001 From: Dan J Miller Date: Tue, 10 Sep 2024 15:32:12 -0230 Subject: [PATCH] fix: Update id for ignoring path-to-regexp advisory (#27044) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** Follow up to https://github.com/MetaMask/metamask-extension/pull/27024 and https://github.com/MetaMask/metamask-extension/pull/27041 The id has changed again, so we are going to try updating one more time. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27044?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- .yarnrc.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.yarnrc.yml b/.yarnrc.yml index 63b9539cbfba..5d4aa7cd4e73 100644 --- a/.yarnrc.yml +++ b/.yarnrc.yml @@ -51,8 +51,7 @@ npmAuditIgnoreAdvisories: # explicitly from our code. As such, this vulneratibility cannot be exploited # by an external / malicious actor. Meanwhile, once we update to v6+, # path-to-regexp will no longer be used. - - 1099499 - - 1099514 + - 1099518 # Temp fix for https://github.com/MetaMask/metamask-extension/pull/16920 for the sake of 11.7.1 hotfix # This will be removed in this ticket https://github.com/MetaMask/metamask-extension/issues/22299