From 456e63f4dc26f0603ff0d4fb3a11de254b642622 Mon Sep 17 00:00:00 2001
From: Priya <priya.narayanaswamy@consensys.net>
Date: Fri, 6 Dec 2024 04:06:59 +0800
Subject: [PATCH] test: fix flaky erc20 send token e2e (#28775)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The issue is that sometimes when clicking on the watchAssets button from
the test dapp the metamask dialog does not open. The test dapp button is
present and enabled but for some reason clicking on it does nothing.
However if you wait for a second and then click this seems to solve the
issue.

Also tried to wait until the page is loaded, element is present, visible
and enabled, however, the flakiness persists. Hence added a hardcoded
wait.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28775?quickstart=1)

## **Related issues**

Fixes:
[#28700](https://github.com/MetaMask/metamask-extension/issues/28700)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Harika <153644847+hjetpoluru@users.noreply.github.com>
---
 .../transactions/erc20-token-send-redesign.spec.ts              | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/e2e/tests/confirmations/transactions/erc20-token-send-redesign.spec.ts b/test/e2e/tests/confirmations/transactions/erc20-token-send-redesign.spec.ts
index 036a8287882c..317d97abef6e 100644
--- a/test/e2e/tests/confirmations/transactions/erc20-token-send-redesign.spec.ts
+++ b/test/e2e/tests/confirmations/transactions/erc20-token-send-redesign.spec.ts
@@ -127,6 +127,7 @@ async function createWalletInitiatedTransactionAndAssertDetails(
 
   await testDapp.openTestDappPage({ contractAddress, url: DAPP_URL });
 
+  await driver.delay(1000);
   await testDapp.clickERC20WatchAssetButton();
 
   await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog);
@@ -172,6 +173,7 @@ async function createDAppInitiatedTransactionAndAssertDetails(
 
   await testDapp.openTestDappPage({ contractAddress, url: DAPP_URL });
 
+  await driver.delay(1000);
   await testDapp.clickERC20WatchAssetButton();
 
   await driver.delay(veryLargeDelayMs);