From 3ae9c4a31b9be9dc53bdaffc64d599abcc087572 Mon Sep 17 00:00:00 2001 From: Charly Chevalier Date: Thu, 29 Aug 2024 11:49:50 +0200 Subject: [PATCH] fix(multichain): fix missing async for CreateBtcAccount.onActionComplete callback ## **Why do we need this fix?** Why do we need this fix? This produces a linting error, now that `account-menu-list` is a `.tsx` file. ## **Why don't we have this error on `develop`?** This is because we are cherry-picking specific commits for BTC fixes, but not all! (otherwise this would introduce much more changes) The commit that converts `account-menu-list.js` to `.tsx` was not using `CreateBtcAccount` on `develop` since this component has been replaced by the new "Snap account creation flow" (which is not part of the v12.2.0). During the merge and conflict resolution, the `CreateBtcAccount` has been kept, and now that we are using TypeScript for this file, this new typing error occurs. --- .../multichain/account-list-menu/account-list-menu.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/components/multichain/account-list-menu/account-list-menu.tsx b/ui/components/multichain/account-list-menu/account-list-menu.tsx index 20ae5232e9d9..8da08644d844 100644 --- a/ui/components/multichain/account-list-menu/account-list-menu.tsx +++ b/ui/components/multichain/account-list-menu/account-list-menu.tsx @@ -273,7 +273,7 @@ export const AccountListMenu = ({ bitcoinSupportEnabled && actionMode === ACTION_MODES.ADD_BITCOIN ? ( { + onActionComplete={async (confirmed) => { if (confirmed) { onClose(); } else {