Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When destroying a PollingBlockTracker, unset the last timer created during the polling loop #128

Open
mcmire opened this issue Jan 30, 2023 · 0 comments
Open

When destroying a PollingBlockTracker, unset the last timer created during the polling loop #128

mcmire opened this issue Jan 30, 2023 · 0 comments
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Jan 30, 2023 •
edited
Loading

Failure to do so is causing "Jest did not exit one second after the test run has completed" in the tests for eth-json-rpc-middleware. See MetaMask/eth-json-rpc-middleware#156.
@mcmire mcmire mentioned this issue Jan 30, 2023
Draft
@mcmire mcmire changed the title When destroying a PollingBlockTracker, unset the last timer created during the polling loop PollingBlockTracker does not stop immediately when stopped Feb 7, 2023
@mcmire mcmire changed the title PollingBlockTracker does not stop immediately when stopped When destroying a PollingBlockTracker, unset the last timer created during the polling loop Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcmire @desi