Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit the controllers to ensure our controller guidelines/templates provide good advice #5174

Open
sethkfman opened this issue Jan 17, 2025 · 0 comments
Open

Audit the controllers to ensure our controller guidelines/templates provide good advice #5174

sethkfman opened this issue Jan 17, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@sethkfman
Copy link
Contributor

This ticket was brought up from an incident that occurred not he mobile client where a controller don't have initial state passed in the Engine which resulted in the contact list being flushed on app restart.

The outcome for this ticket will be to audit the controllers to ensure our controller guidelines/templates provide good advice on initial state.

Related issue: MetaMask/metamask-mobile#12044
Fix: MetaMask/metamask-mobile#12089
@sethkfman sethkfman added the enhancement New feature or request label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sethkfman