Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create more informative error logs #5068

Open
Prithpal-Sooriya opened this issue Dec 13, 2024 · 0 comments
Open

Create more informative error logs #5068

Prithpal-Sooriya opened this issue Dec 13, 2024 · 0 comments
Labels
team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications

Comments

@Prithpal-Sooriya
Copy link
Contributor

Notification/Identity team related.

I'm looking through sentry at some of our error logs we emit, I think we can do a better job at adding some metadata to these logs.

Fetch requests:

  • add status code (this will help us differentiate 400, 500, 431, 413, ..., errors)
  • maybe add the endpoint that we were trying to hit
  • profileId can also be handy if we need to perform additional back-end investigations.

Impossible states

  • for sections of our typescript code that we deemed impossible to reach, lets add the variable/s that could have caused it to reach those areas.

Failure states

  • for sections we've marked as failure states, lets try to add additional metadata to inform us on why these failed
@Prithpal-Sooriya Prithpal-Sooriya added team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Development

No branches or pull requests

1 participant