NftController.updateNftMetadata called with too many NFTs at once causes 429 error

[zakariamouhid]

Issue

I have about 1949 nfts on base sepolia testnet
using sepolia.base.org as a provider
most of those nfts are testing nfts that have broken images (empty string)
the NftController.updateNftMetadata is beign called with too many nfts at once (see attached images)

Cause

the issue is caused by using Promise.all to call getNftInformation

core/packages/assets-controllers/src/NftController.ts

Lines 1582 to 1594 in 5d9f45c

	const nftMetadataResults = await Promise.all(
	nftsWithChecksumAdr.map(async (nft) => {
	const resMetadata = await this.#getNftInformation(
	nft.address,
	nft.tokenId,
	networkClientId,
	);
	return {
	nft,
	newMetadata: resMetadata,
	};
	}),
	);

Proposed Solutions

instead should limit the number of the getNftInformation calls at once
could use one of those packages
https://www.npmjs.com/package/promise-concurrency
https://www.npmjs.com/package/promise-limit
or should only refresh a few broken nfts each time, and keep track of the last updated timestamp

Images from MetaMask extension service worker on chrome