Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PAPU Token to contract-map.json #1374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@paputoken paputoken requested review from MRabenda and a team as code owners October 11, 2024 12:58
@MRabenda MRabenda added the bsc label Oct 11, 2024
@paputoken
Copy link
Author

Hi @MRabenda,

Is there anything we can do more, or we just need to wait for the confirmation to merge on your side ?

@MRabenda
Copy link
Collaborator

Hello @paputoken 👋 ;
At this point of time that repository supports only Ethereum mainnet, would you be able to add the token to the following lists?:
Coingecko: https://tokens.coingecko.com/polygon-pos/all.json
sushiswap: https://token-list.sushi.com/
UniswapLabs: https://gateway.ipfs.io/ipns/tokens.uniswap.org

@paputoken
Copy link
Author

Hello @MRabenda,

How can we handle to add PAPU for BSC network? Is there any way to add our token to be searchable on Metamask Wallet?
(If we follow the following lists you have mentioned would it be added ?)

And We have listed on Coingecko already. But our logo in Metamask is the old one, how can we change it to updated one?

Thank you for your interest and time.

@paputoken
Copy link
Author

Hello again @MRabenda,

https://tokens.coingecko.com/binance-smart-chain/all.json

We have seen that our new logo is here, but in metamask it is our old logo, and we are not searchable in metamask only as customized token we can import our token

@sahar-fehri
Copy link

sahar-fehri commented Oct 16, 2024

Hello @paputoken 👋
Thank you for reaching out 🙏

We see that you have your token listed in two of our lists:
pancakeCoinMarketCap: 'https://tokens.pancakeswap.finance/cmc.json',
pancakeCoinGecko: 'https://tokens.pancakeswap.finance/coingecko.json'

In order for the token to be searchable on MM; would you be able to add it to at least one of these lists
uniswapLabs: 'https://gateway.ipfs.io/ipns/tokens.uniswap.org',
sushiswap: 'https://token-list.sushi.com',
apeswap:
'https://raw.githubusercontent.com/ApeSwapFinance/apeswap-token-lists/main/lists/apeswap.json',

Also i think for the two lists we have; pancakeCoinMarketCap: 'https://tokens.pancakeswap.finance/cmc.json', seems to have the correct icon right? icon: https://s2.coinmarketcap.com/static/img/coins/64x64/31496.png;

If this list https://tokens.pancakeswap.finance/coingecko.json does not have the correct icon, then could you guys update the icon on the list?

@paputoken
Copy link
Author

If this list https://tokens.pancakeswap.finance/coingecko.json does not the correct icon, then could you guys update the icon on the list?

Thank you for your help. 🙏

The link https://tokens.pancakeswap.finance/coingecko.json contains the correct icon. All of them have the correct icon. It's just that Metamask hasn't been updated.Thank you for the information. Our new logo is visible and correct in all CMC and CoinGecko JSON files, as well as all other files.

Best Regars

@sahar-fehri
Copy link

sahar-fehri commented Oct 16, 2024

Hey @paputoken thanks for the quick reply 🙏
Just want to make sure we are aligned.

Its great to know that both of the lists
pancakeCoinMarketCap: 'https://tokens.pancakeswap.finance/cmc.json',
pancakeCoinGecko: 'https://tokens.pancakeswap.finance/coingecko.json'
Have your correct icon URL;

Still, for the token to be searchable on MM; it will need to be added to at least one more list;
Could you choose at least one of the following lists and add your token to it:

@paputoken
Copy link
Author

Hi @sahar-fehri

We have applied to both sushiswap and apeswap, still waiting for the merge to be done. While waiting the merge, can you update our logo with this latest one, the search part we can handle later on.

Kind regards.

@paputoken
Copy link
Author

Hi,

@MRabenda @sahar-fehri @jflatow @mcmire

Regards

@paputoken
Copy link
Author

Hi,

Please logo updated. @MRabenda @sahar-fehri @jflatow @mcmire
Because they still haven't responded to the other request we submitted.

@sahar-fehri
Copy link

Hi @paputoken ! Apologies for the late reply 🙏
We will need to be able to retrieve the token first and then the logo will be automatically displayed correctly.
I think we will need to wait for the token to be merged to the lists; and then it should be both searchable and the logo should be displayed properly

@paputoken
Copy link
Author

Hello @sahar-fehri, not problem,

We have been waiting for updates for over a month, but they haven't been updated. Could you at least update our logo?

Regards

@sahar-fehri
Copy link

sahar-fehri commented Nov 21, 2024

Hey @paputoken ,
Sorry maybe i was not very clear 🙏
I also understand that unfortunately the lists are not always quick to update.

The way we are displaying the logo is that we are making a call to one of our APIs which returns the tokens with their details including the image.
Because the changes you made to add to the lists were not merged yet, the api is not returning the token.
We can't update the logo because the token is not returned by the api in the first place. We need at least one of the lists you guys applied for (sushiswap or apeswap) to merge the token before the api is able to return it

@paputoken
Copy link
Author

Dear @sahar-fehri, Thank you very much for your interest, we will get back to you.🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants