Support for editable states and alias expressions for fields #3645
+124
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasMizera
reviewed
Oct 17, 2024
VitorVieiraZ
changed the title
Pull Request Test Coverage Report for Build 11978385757Details
💛 - Coveralls |
tomasMizera
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Nice :) I have just a bunch of small comments, but generally it looks good 👍🏻 @uclaros can I ask you to have a look here please?
uclaros
approved these changes
Nov 20, 2024
tomasMizera
requested changes
Nov 22, 2024
Comment on lines
268
to
+269
| !isReadOnly, | ||
| editableExpression, |
There was a problem hiding this comment.
We are still missing the logic when there is "default value on update enabled". In that case we do not want to set the field to be editable. Let's not read the expression in case field.defaultValueDefinition().applyOnUpdate() is set (see line https://github.com/MerginMaps/mobile/pull/3645/files#diff-1cac530c00b6b3114d6f3da9d8dc0fefd2a486a7eefc58814e9e8dd1c0da69acR255)
There was a problem hiding this comment.
Issue resolved:
(Test2 with default value on update enabled is not editable even when Editable expression returns true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-10-17.at.08.28.44.mov
Resolves #2607, Resolves #3494