Docker aws #1
Open
Docker aws #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update readme * Update README.md Co-authored-by: Satyam Bajpai <[email protected]> * Update README.md Co-authored-by: Satyam Bajpai <[email protected]> * Update README.md Co-authored-by: Satyam Bajpai <[email protected]> * update auth link * update tokens * format code * update public key * update public key * update tokens * fix readme * Update README.md Co-authored-by: Akhil Khubchandani <[email protected]> * address review comments --------- Co-authored-by: Satyam Bajpai <[email protected]> Co-authored-by: Akhil Khubchandani <[email protected]>
…Public Key Size limitation issue (Real-Dev-Squad#115)
* Added integration tests for endorsement service * Added test suite for integration tests * testing separation of unit and integration ci and pomxml * Addressed review comments and added build step in CI * Fix API contract and added pagination assertions to integration tests * Fixing typos and addressing review comments * Addressed review comments * Addressed review comments * Addressed review comments --------- Co-authored-by: akhil <[email protected]>
…flow kept intact, tests updated
* feat: Create updateEndorsementStatus API * feat: Implement role restrictions in updateEndorsementStatus API * feat: improve logic for updateEndorsementStatus API * fix: switch to InsufficientAuthenticationException (401, Unauthorized) if user in not superuser * chore: update return message for updateEndorsementStatus * temp: validate endorsementId for updateEndorsementStatus UUID.fromString does not throw exception in case of "1-1-1-1-1". Hence temporarily validating it until Real-Dev-Squad#109 is merged. * chore: update switch to string.equals() to compare endorsement status * chore: update exceptions for update-endorsement-status * fix: switch to AccessDeniedException to handle Unauthorized * chore: move isValidUUID out of UUIDValidationInterceptor * fix: remove unnecessary RuntimeException * chore: update api-contracts * fix: match endorsementId with the DB * chore: handle endorsement status already updated case and handle invalid status * fix: remove unnecessary validations * fix: simply endorsement status check AS we are checking for invalid status via `EndorsementStatus.fromString()` we can simply condition to check for `PENDING` status * fix: api-contracts
* chore: create handleIllegalArgumentException * chore: unit tests for updateEndorsementStatus * fix: remove unnecessary stubbings * add boilerplate code for feat: update-endorsement-status * disable unit tests for update-endorsement-status for now * fix: switch to InsufficientAuthenticationException (401, Unauthorized) if user in not superuser * chore: add integration tests for update endorsement status * fix: code formatting * fix: assign userId instead of skillId in createEndorsement * move user role setup to a common function named setupUpdateEndorsementTests * fix: use superuser cookie in test 'Return 401 when request is made without using superuser cookie' * fix: 'detached entity passed to persist' exception for integration tests * fix: Formatting * chore: update message in case of Unauthorized access for updateEndorsementStatus * chore: Add more assertions to `UpdateEndorsementStatusGivenEndorsementId` * fix: use correct pathParam format and clearer message for unauthorized access * chore: update exception messages for update-endorsement-status * fix: update exceptions and fix test cases * chore: update tests according to the feature * chore: add more test cases for endorsement already updated case * chore: enable tests for update endorsement
* update create endorsement * fix endorsement test * fix endorsement test * fix endorsement test * fix endorsement test * delete file * change endorseeId * remoce file * fix integration test * remove file * develop branch merged * remove file * fix build and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.