Will ABP have to do something to get performance benefit?

[sturlath]

I just saw this discussion and noticed some huge performance gains there but then saw the following comment

Because

ABP has it's IComponentActivator
They're using Blazorise for Blazor implementation
And with IComponentDisposer we've only focused on Microsoft DI and ServiceProviderEngineScope implementation. In the ABP > framework, you as a user can choose to form multiple different DI libraries. Meaning our IComponentDisposer will not work in all > cases.

So, my question is whether ABP will get them out of the box with their update to 1.1.3 or if something needs to be done?

I´m trying to find anything that can make ABP.io WASM faster and stumbled on this issue when trying to figure out some Document is not focused. at ee line null, column null (null:null) (I´m trying to log more information to know where this comes from so I´m not 100% if my issue is related to this PR)

[David-Moreira]

It should be on by default if the default DI is used.
Unless apb has specifically overriden our implementation.

@stsrki do you have more concrete info about this?

[stsrki]

Yeah, in ABP, they have their own IComponentActivator. It is basically a default implementation that on it's doesn't do much. My advice would be to override it with Blazorise for the best performance.

[David-Moreira]

Basically you should see how fast Blazorise is without apb for your use case and compare...
It might be something on apb...

[sturlath]

I have been experiencing come mem leaks so I would love to have it. It would surprise me if abp.io wouldn´t be interested getting that. And yes, Blazorise without abp is much more performant at the moment (even a bare bone apb version)... and WASM doesn´t have much priority it seems.. so I´m trying to search for everything to make it perform little better..

[stsrki]

We register services as scoped, while ABP registers them as transient. See for reference https://github.com/Megabit/Blazorise/blob/master/Source/Blazorise/Config.cs#L30

It should be enough if you just re-register IComponentActivator as scoped, BUT sometime after the ABP register it with their modules import.

Eg.

services.Replace(ServiceDescriptor.Scoped<IFoo, FooB>());

[sturlath]

OK I´ll try this after we have updated the abp next month..

[sturlath]

Just wanted to add a link to the performance issue at abp for those that are interested.