[50.01] Seeker DS crew count / weight calculation error on removing cargo bay?

[gsparks3]

Prerequisites and Pre-Issue Checklist

• I'm reporting the issue to the correct repository:

• MegaMek

• MegaMekLab

• MekHQ

• I've tested the issue against at least the latest MILESTONE version

• I've asked on the MegaMek Discord about the error

• I've reviewed the BattleTech rules and MegaMekLab documentation, and I've confirmed that something isn't working as intended.

• I've searched the Github tracker and haven't found the issue listed

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

Removing a specific cargo bay from a specific DropShip in MML causes the crew count validation to bug out. Cause unknown, and whether it affects other units is also unknown, but it is very easily reproducible.

Original crew and quarters:

Crew and quarters after removing cargo bay:

Crew and quarters after clicking in and out of the Year entry box (which seems to force an update of some sort):

Unit weight prior to removing 300 ton cargo bay:

Unit weight after removing 300 ton cargo bay:

(the missing 1 ton in the original weight may be due to an issue with loading the MASH Theater, which I believe is already known and fixed in the nightly build - however, an otherwise identical issue to the above can be observed as far back as MML from version 0.48 as well as in version 0.50.01)

Steps to Reproduce

1. Open MML and load the Seeker (2815) (Mech) from cache.
2. Go to the Transport Bays tab and remove the 300 ton cargo bay with 0 doors.
3. Observe that (a) the unit weight has not decreased by 300 tons, (b) the unit now shows as Invalid, and (c) the crew count is now listed as -988.
4. (Optional) Restart from step 1, but remove other bay(s) instead. Removing the Light Vehicle Bay or the first Mek Bay instead of the 300 ton cargo bay causes similar issues. Removing any of the other bays does not seem to cause similar issues. Moving bays up or down in the list via click-and-drag can also cause issues (but not always, depending on which bay you move and where to).

Operating System *

Windows 10

Java Version *

17.0.11

MegaMek Suite Version *

Free Text (type manually)

Custom MegaMekLab Version

v0.50.01

Attach Files

No response

Final Checklist

• I've checked to make sure that this issue has not already been filed
• I'm reporting only one issue in this ticket for clarity and focus

[IllianiCBT]

We should test this in 50.02. I believe it has already been fixed, but I'm on a time crunch as can't verify myself.

[gsparks3]

Just tested with this (MML-only) artifact: https://github.com/MegaMek/megameklab/actions/runs/12192423714

Same error.

[gsparks3]

I think this might be more related to the Infantry (Foot) bay - when attempting to recreate a custom variant from scratch in 49.20 to see if the bug persisted, I found that moving other bays around tended to cause the Size of the Infantry (Foot) bay to jump from 5 to 25, which also resulted in weight and personnel count issues. Resetting its size to 5 and clicking in and out of the Year entry box seemed to temporarily resolve the issue.