Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds overload to BLK file and updates BuildingBlock #6206

Closed

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Nov 17, 2024

Allows calling the building block with a File, necessary for supporting tests that need file ref, or processes that want to manipulate the files after saving.

This change is necessary to support testing involving saving and reloading entity files on MML

@Scoppio Scoppio changed the title feaat: Adds overload to BLK file and updates BuildingBlock feat: Adds overload to BLK file and updates BuildingBlock Nov 17, 2024
@Scoppio Scoppio self-assigned this Nov 17, 2024
@Scoppio Scoppio force-pushed the feat/blkfile-and-buildingblock branch from bde5534 to b5e561a Compare November 17, 2024 21:24
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.18%. Comparing base (46d2315) to head (b5e561a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6206      +/-   ##
============================================
- Coverage     29.18%   29.18%   -0.01%     
+ Complexity    13981    13979       -2     
============================================
  Files          2628     2628              
  Lines        266565   266565              
  Branches      47576    47576              
============================================
- Hits          77791    77788       -3     
- Misses       184890   184895       +5     
+ Partials       3884     3882       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Scoppio Scoppio closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant