Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SRMAXHandler to ignore specialty armors. #6201

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

stonewall072
Copy link
Contributor

Added HitData.DAMAGE_IGNORES_DMG_REDUCTION to SRMAXhandler to make Acid SRMs in line with errata and close #5086.

@stonewall072
Copy link
Contributor Author

@rjhancock is this right? Sorry, first time doing any of the Git stuff.

@rjhancock
Copy link
Collaborator

Yup. This keeps your code base clean and allows you to keep pulling in the latest changes, branching off to do whatever you want/need to do, and then requesting they get merged here.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.18%. Comparing base (a28fd13) to head (cca2e84).
Report is 55 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6201      +/-   ##
============================================
+ Coverage     29.09%   29.18%   +0.08%     
+ Complexity    13981    13979       -2     
============================================
  Files          2647     2628      -19     
  Lines        267373   266566     -807     
  Branches      47650    47576      -74     
============================================
- Hits          77793    77788       -5     
+ Misses       185696   184896     -800     
+ Partials       3884     3882       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS HammerGS merged commit 68c315c into MegaMek:master Nov 23, 2024
6 checks passed
@stonewall072 stonewall072 deleted the AXChange branch December 4, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.49.17] Acid SRMs doing incorrect damage against units with ferro-lamellor armor.
3 participants