Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an advanced search for boards to the lobby #6196

Merged
merged 17 commits into from
Nov 23, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Nov 10, 2024

  • add an advanced search for boards to the lobby
  • allows searching across board sizes
  • filter by map tags
  • filter by map path
  • filter by width, height, and name
  • sort by the name or size
  • selected board replaces any previous boards with the new selection when completing the dialog
  • disable when using space map
  • disable when map page size is not 1x1

image
image
image
image

fixes #433

@kuronekochomusuke kuronekochomusuke marked this pull request as draft November 10, 2024 03:10
@kuronekochomusuke kuronekochomusuke added the GUI User Interface label Nov 10, 2024
@HammerGS
Copy link
Member

This is so cool.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.14%. Comparing base (474def9) to head (9cdff42).
Report is 69 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6196   +/-   ##
=========================================
  Coverage     29.14%   29.14%           
  Complexity    13981    13981           
=========================================
  Files          2630     2630           
  Lines        266881   266877    -4     
  Branches      47596    47598    +2     
=========================================
  Hits          77791    77791           
+ Misses       185206   185202    -4     
  Partials       3884     3884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS
Copy link
Member

Been playing around with this and it's awesome. But I noticed the size filter doesn't seem to sort correctly
image

Made be realize our Boards folder is in a bit of sorry state with the names all over the place and lots of duplicates.

Do you think there would be a way to identify duplicate boards?

The width and height is cool, but took me a couple of tries to get the usage correct. Maybe a helper tip?

@kuronekochomusuke
Copy link
Collaborator Author

kuronekochomusuke commented Nov 11, 2024

the size sorts as a string that is why it sorts that way. could try 0 padding the width and height to get it to sort correctly.

could try doing a check sum in the BoardsTagger and logging it there. not sure if it would get them, the file may not be always written is the same order. so if the order is slightly different they would show as different, even though they would produce the same map. maybe have it write out the preview images into a temp folder and then doing a compare on those would be better.

there are also some that look like the would only differ by the theme. since you can not select the theme for the board, multiple were made with different themes.

can try adding a tooltip for the width and height inputs.

@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review November 17, 2024 16:52
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been testing and seems to work with no issues.

@HammerGS HammerGS merged commit 518b8ab into MegaMek:master Nov 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI User Interface Map and Board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Ability to search a Map Board by Name/Size/Features
2 participants