-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an advanced search for boards to the lobby #6196
add an advanced search for boards to the lobby #6196
Conversation
This is so cool. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6196 +/- ##
=========================================
Coverage 29.14% 29.14%
Complexity 13981 13981
=========================================
Files 2630 2630
Lines 266881 266877 -4
Branches 47596 47598 +2
=========================================
Hits 77791 77791
+ Misses 185206 185202 -4
Partials 3884 3884 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
the size sorts as a string that is why it sorts that way. could try 0 padding the width and height to get it to sort correctly. could try doing a check sum in the BoardsTagger and logging it there. not sure if it would get them, the file may not be always written is the same order. so if the order is slightly different they would show as different, even though they would produce the same map. maybe have it write out the preview images into a temp folder and then doing a compare on those would be better. there are also some that look like the would only differ by the theme. since you can not select the theme for the board, multiple were made with different themes. can try adding a tooltip for the width and height inputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been testing and seems to work with no issues.
fixes #433