From dfa44bcd3382656fd572ee0d62d52ba928b6942e Mon Sep 17 00:00:00 2001
From: Boubaker Khanfir <boubaker.khanfir@gmail.com>
Date: Tue, 3 Dec 2024 16:07:59 +0100
Subject: [PATCH] feat: Review Favorite Tab Placeholder Label - MEED-7852 -
 Meeds-io/MIPs#159

---
 .../resources/locale/portal/HamburgerMenu_en.properties   | 3 +--
 .../sidebar/components/space/SpacesNavigationEmpty.vue    | 8 +-------
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/webapp/src/main/resources/locale/portal/HamburgerMenu_en.properties b/webapp/src/main/resources/locale/portal/HamburgerMenu_en.properties
index 90429b983e1..445e3748c50 100644
--- a/webapp/src/main/resources/locale/portal/HamburgerMenu_en.properties
+++ b/webapp/src/main/resources/locale/portal/HamburgerMenu_en.properties
@@ -36,8 +36,7 @@ menu.spaces.favorite=Favorite
 menu.spaces.unread=Unread
 menu.spaces.yourSpaces=Your Spaces
 menu.spaces.noUnreadSpaces=No unread activities here
-menu.spaces.noFavoriteSpaces1=You haven't marked any space as a favorite
-menu.spaces.noFavoriteSpaces2=Go to the {0}Spaces{1} page to do so
+menu.spaces.noFavoriteSpaces=You haven't marked any space as a favorite
 menu.spaces.openSidebarTooltip=Open Sites page links
 menu.spaces.addNewSpaceTooltip=Filter by space
 menu.spaces.filterBySpaceTooltip=Filter by space
diff --git a/webapp/src/main/webapp/vue-apps/sidebar/components/space/SpacesNavigationEmpty.vue b/webapp/src/main/webapp/vue-apps/sidebar/components/space/SpacesNavigationEmpty.vue
index abd698e61d8..c03ebd7c77a 100644
--- a/webapp/src/main/webapp/vue-apps/sidebar/components/space/SpacesNavigationEmpty.vue
+++ b/webapp/src/main/webapp/vue-apps/sidebar/components/space/SpacesNavigationEmpty.vue
@@ -29,14 +29,8 @@
     <template v-else-if="filterType === 'favorite'">
       <v-icon class="tertiary-color" size="60">fa-star-half-alt</v-icon>
       <div class="my-6">
-        {{ $t('menu.spaces.noFavoriteSpaces1') }}
+        {{ $t('menu.spaces.noFavoriteSpaces') }}
       </div>
-      <div
-        v-if="!isExternalUser"
-        v-sanitized-html="$t('menu.spaces.noFavoriteSpaces2', {
-          0: `<a href='${spacesLink}'>`,
-          1: '</a>',
-        })"></div>
     </template>
     <template v-else>
       <v-icon class="tertiary-color" size="60">fa-people-arrows</v-icon>