Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation] Under MD device, clicking to a link item opens an empty page #2622

Open
margondicco opened this issue Nov 28, 2024 · 1 comment
Open

[Navigation] Under MD device, clicking to a link item opens an empty page #2622

margondicco opened this issue Nov 28, 2024 · 1 comment

Comments

@margondicco
Copy link

margondicco commented Nov 28, 2024 •
edited by srenault-meeds
Loading

Steps to reproduce

Given adding an item in a site
When choosing link and add an url from the plateform (as /portal/meeds/spaces or /portal/s/4 )
Name this item "Link test"
Then I can choose to make it open in a new tab or not

Current behavior

  • Use a device with a width below MD breakpoint (less than 960px)
  • Site navigation is proposed at the tabbar (bottom of device)
  • Click to this link item
  • Page opens as empty

Instead of opening the link, it opens this link indeed:
[DomainName]meeds.io/portal/mycraft/dashboard/linktest

Vidéo
@margondicco
Copy link
Author

cc @srenault-meeds

@srenault-meeds srenault-meeds changed the title [Navigation] under 944px, empty page opens when i click on an item of the bottom bar [Navigation] Under MD devic, licking to a link item opens an empty page Nov 29, 2024
@srenault-meeds srenault-meeds changed the title [Navigation] Under MD devic, licking to a link item opens an empty page [Navigation] Under MD device, clicking to a link item opens an empty page Nov 29, 2024
@srenault-meeds srenault-meeds moved this to Doing in Bug Hunt Nov 29, 2024
boubaker added a commit to Meeds-io/social that referenced this issue Dec 1, 2024
@boubaker
fix: Fix Navigation Url when external link - MEED-7881 - Meeds-io/mee…
9031b3d 
…ds#2622

Prior to this change, the external link behavior wasn't the same switch Navigation Node display mode:
- Desktop Menu Item
- Desktop Menu Sub item (displayed in Second or Third Level)
- Mobile Menu Item
- Mobile Menu Sub item (displayed in Second or Third Level)

Thus, when clicking on external link in Mobile, the behavior is just to open the URL as it was a current page URL.
This change will introduce the usage of **AutoLink** API in order to ensure the URL behavior consistency comparing to provided link by the user.
In addition, when a Dash is used in user provided URL, the behavio has been improved to always open the URL and not let the builtin behavior occurs, which will not change to the opened page.
boubaker added a commit to Meeds-io/social that referenced this issue Dec 1, 2024
@boubaker
fix: Fix Navigation Url when external link - MEED-7881 - Meeds-io/mee…
a9e8943 
…ds#2622

Prior to this change, the external link behavior wasn't the same switch Navigation Node display mode:
- Desktop Menu Item
- Desktop Menu Sub item (displayed in Second or Third Level)
- Mobile Menu Item
- Mobile Menu Sub item (displayed in Second or Third Level)

Thus, when clicking on external link in Mobile, the behavior is just to open the URL as it was a current page URL.
This change will introduce the usage of **AutoLink** API in order to ensure the URL behavior consistency comparing to provided link by the user.
In addition, when a Dash is used in user provided URL, the behavio has been improved to always open the URL and not let the builtin behavior occurs, which will not change to the opened page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Bug Hunt
Status: Doing
Milestone
No milestone
Development

No branches or pull requests
1 participant
@margondicco